-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment defined in plan is ignored when importing a plan #2446
Comments
@LecrisUT could you bit expand more what is exactly the problem here pls? |
Hi @thrix. Basically, if we call a tmt plan with: # /plans/rpminspect
plan:
import:
url: https://github.com/LecrisUT/tmt-plans
ref: doc/rpminspect
name: /plans/rpminspect
environment:
RPMINSPECT_EXCLUDE: disttag The configuration in |
thrix
changed the title
Editing imported plan does not work on testing-farm
Environment defined in plan is ignored when importing a plan
Nov 3, 2023
thrix
added a commit
to thrix/tmt
that referenced
this issue
Nov 3, 2023
The `environemnt` is a property of the `Plan` class that modifies the plan environment stored in the `_environment` dictionary. If we call `update` on the dictionary it does not really modify the `_environment` dictionary. I believe we need to modify the `_environment` dictionary Resolves teemtee#2446 Signed-off-by: Miroslav Vadkerti <[email protected]>
2 tasks
thrix
added a commit
to thrix/tmt
that referenced
this issue
Nov 28, 2023
The environment from the importing plan was ignored. As agreed, let's make the `environment` a cached property and inherit the importing plan environment automatically. Resolves teemtee#2446 Signed-off-by: Miroslav Vadkerti <[email protected]>
thrix
added a commit
to thrix/tmt
that referenced
this issue
Nov 28, 2023
The environment from the importing plan was ignored. As agreed, let's make the `environment` a cached property and inherit the importing plan environment automatically. Resolves teemtee#2446 Signed-off-by: Miroslav Vadkerti <[email protected]>
psss
pushed a commit
to thrix/tmt
that referenced
this issue
Dec 5, 2023
The environment from the importing plan was ignored. As agreed, let's make the `environment` a cached property and inherit the importing plan environment automatically. Resolves teemtee#2446 Signed-off-by: Miroslav Vadkerti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description (added by @thrix)
Looks like environment defined in the plan is ignored when importing a plan:
It ignored the
SCRIPT
env variable.Original report
Executor: scikit-build/scikit-build-core#518
Imported plan: packit/tmt-plans#7
Could it be a clash with testing-farm's setting of
environment
, i.e. the-e @tmt-environment-plans-rpminspect.yaml
in$ /usr/bin/tmt --root .distro -c arch=x86_64 -c distro=fedora-rawhide -c initiator=packit -c trigger=commit run --all --verbose --id /var/ARTIFACTS/work-rpminspectb7tmges9 -e @tmt-environment-plans-rpminspect.yaml provision --how connect --guest 18.117.129.38 --key /etc/citool.d/id_rsa_artemis --port 22 plan --name '^/plans/rpminspect$'
Looking at the code, it shouldn't:
tmt/tmt/base.py
Lines 1668 to 1683 in 7552550
But the
log.txt
file indicates otherwise 🤔Or myabe it involves:
tmt/tmt/base.py
Lines 1558 to 1565 in 7552550
The text was updated successfully, but these errors were encountered: