Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use downstream tmt plans #518

Merged
merged 3 commits into from
Dec 15, 2023
Merged

ci: Use downstream tmt plans #518

merged 3 commits into from
Dec 15, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Oct 2, 2023

This was referenced Oct 3, 2023
Merged
Closed
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Oct 31, 2023 •
edited
Loading

I'm confused why the tmt tests are passing now even though the PRs above didn't land.

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Oct 31, 2023 •
edited
Loading

/packit test

@LecrisUT LecrisUT mentioned this pull request Oct 31, 2023
Closed
@henryiii
Copy link
Collaborator

henryiii commented Nov 8, 2023

Main branch seems to be passing now, still needed?

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Nov 8, 2023 •
edited
Loading

Yeah, it will be less maintainence in the long-run. Probably next week one of the bug-fixes will land and we can merge this. Oh, the bug-fix already landed, just need to clean-up a bit

@LecrisUT LecrisUT force-pushed the packit/downstream-tmt branch 2 times, most recently from 803a4b7 to da20067 Compare November 8, 2023 08:24
@LecrisUT LecrisUT marked this pull request as ready for review November 8, 2023 08:27
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Nov 8, 2023

This one is ready for merging

@LecrisUT
Copy link
Collaborator Author

Oh, interesting, I will report the current testing-farm failure upstream. Can ignore it otherwise

@LecrisUT LecrisUT marked this pull request as draft December 13, 2023 15:46
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Dec 13, 2023 •
edited
Loading

Made this a draft until packit/tmt-plans#7 is merged and I remove d825a08 commit. Just want to test that these tests are resolved with the recent fixes upstream. All merged and resolved now

@LecrisUT LecrisUT marked this pull request as ready for review December 15, 2023 10:07
@henryiii henryiii merged commit a6f3418 into scikit-build:main Dec 15, 2023
47 checks passed
@LecrisUT LecrisUT deleted the packit/downstream-tmt branch December 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LecrisUT @henryiii