Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to verify certificate/ca from server are valid #397

Closed
SimonHooker opened this issue Jun 24, 2016 · 2 comments · Fixed by #419
Closed

Unable to verify certificate/ca from server are valid #397

SimonHooker opened this issue Jun 24, 2016 · 2 comments · Fixed by #419

Comments

@SimonHooker
Copy link
Contributor

SimonHooker commented Jun 24, 2016 •
edited
Loading

With encrypted=true I expect connection to a server with a self-signed certificate to fail due to the CA not being trusted. Connecting though silently accepts the certificates.

Digging through the tls source this looks to be functionality supported by tls.tlsSocket() but not by tls.createSecurePair()

tls.createSecurePair() is deprecated as of node 6.x ( previously reported in #135 ) and so this might be good time to look at migrating over to using tls.tlsSocket as it will allow for connections to reject if unauthorised.

This may be considered a duplicate of #282
@SimonHooker
Copy link
Contributor Author

Have started work on what will hopefully work to allow this functionality - just needs a bit more work and hopefully some tests around it

SimonHooker@d691dac

@SimonHooker
Copy link
Contributor Author

Have submitted a pull request

#399

arthurschreiber pushed a commit that referenced this issue Aug 6, 2016
@arthurschreiber
Add options.trustServerCertificate.
649d6dc 
This allows accepting or rejecting a connection to a server that presents an untrusted certificate.

This fixes #397 and #399.
@arthurschreiber arthurschreiber mentioned this issue Aug 6, 2016
Merged
tvrprasad pushed a commit to tvrprasad/tedious that referenced this issue Sep 11, 2016
@tvrprasad
Add options.trustServerCertificate.
84d7f32 
This allows accepting or rejecting a connection to a server that presents an untrusted certificate.

This fixes tediousjs#397 and tediousjs#399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add options.trustServerCertificate. tediousjs/tedious
1 participant
@SimonHooker