Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createSecurePair() is deprecated, use TLSSocket instead #135

Closed
patriksimek opened this issue Mar 10, 2014 · 3 comments
Closed

createSecurePair() is deprecated, use TLSSocket instead #135

patriksimek opened this issue Mar 10, 2014 · 3 comments
Labels

Comments

@patriksimek
Copy link
Collaborator

No description provided.

@patriksimek patriksimek self-assigned this Mar 10, 2014
@patriksimek patriksimek removed their assignment Mar 19, 2014
@bretcope
Copy link
Member

This doesn't actually appear to be deprecated. http://nodejs.org/api/tls.html#tls_tls_createsecurepair_context_isserver_requestcert_rejectunauthorized

There is a note which says:

NOTE: cleartext has the same APIs as tls.TLSSocket

But I don't see anything about deprecation.

Upon further digging, it looks like it was once deprecated, but the deprecation notice was removed in 0.11.15.

@SimonHooker
Copy link
Contributor

SimonHooker commented Jun 24, 2016

This looks like it has since been deprecated according to
https://nodejs.org/api/tls.html#tls_tls_createsecurepair_context_isserver_requestcert_rejectunauthorized_options

Referenced in this commit in node 6.0 ( so not LTS yet ) - the favoured tls.tlsSocket is present in 4.x
nodejs/node#6063

And referenced in these meeting minutes from May 2016
https://github.com/nodejs/node/blob/7f1111b1bb3f1af777e062cd7ca62dd0dc0fc8e0/doc/ctc-meetings/2016-05-04.md

@arthurschreiber
Copy link
Collaborator

After a long time of back and forth, this was finally (and properly) fixed via #738. [email protected] is now available on npm. It's currently tagged as next and I'll make sure it will be tagged as latest soon-ish.

Thanks everyone for your patience and help in getting this fixed! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants