Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KFP V2 upgrades #28

Merged
20 commits merged into from
Aug 5, 2023
Merged

KFP V2 upgrades #28

20 commits merged into from
Aug 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2023 •
edited by ghost
Loading

Description

  • Updated repo for KFP V2
  • Updated Python version to 3.9
  • Updated training step to use @container_component with a custom training container
  • Implemented a custom serving container
  • Simplified champion/challenger deployment
  • Removed Tensorflow pipelines to simplify codebase
  • Compiled pipelines now uploaded to Artifact Registry instead of GCS
  • CI/CD and developer scripts updated in line with the above
  • Lots of documentation updates!

How has this been tested?

  • Successfully run training + prediction pipelines end-to-end (both with and without a champion-challenger comparison)
  • Tested developer scripts manually
  • Tested CI/CD pipelines (incl release pipeline to compile+publish pipelines)

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

@ghost ghost force-pushed the feat/kfp_v2 branch from 8700c78 to bfa2904 Compare July 19, 2023 21:45
@ghost ghost force-pushed the feat/kfp_v2 branch from 2d8397a to 15b4c98 Compare July 27, 2023 08:08
@ghost ghost force-pushed the feat/kfp_v2 branch from d51ac9c to e0939cf Compare July 27, 2023 17:45
@ghost ghost marked this pull request as ready for review July 27, 2023 18:03
@ghost
Copy link
Author

ghost commented Jul 27, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from 168ce48 to 4324ca2 Compare July 28, 2023 08:15
@ghost
Copy link
Author

ghost commented Jul 28, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from 4324ca2 to e4d1892 Compare July 28, 2023 08:20
@ghost
Copy link
Author

ghost commented Jul 28, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from e4d1892 to aa2748b Compare July 28, 2023 08:43
@ghost
Copy link
Author

ghost commented Jul 28, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from aa2748b to c744956 Compare July 28, 2023 09:28
@ghost
Copy link
Author

ghost commented Jul 28, 2023

/gcbrun

1 similar comment
@ghost
Copy link
Author

ghost commented Jul 28, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from e2da6fe to 6ba2298 Compare July 28, 2023 11:06
@ghost
Copy link
Author

ghost commented Jul 28, 2023

/gcbrun

@ghost
Copy link
Author

ghost commented Jul 29, 2023

/gcbrun

@ghost ghost changed the title WIP: KFP V2 KFP V2 upgrades Aug 1, 2023
@ghost ghost requested a review from felix-datatonic August 1, 2023 13:26
@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

@ghost
Copy link
Author

ghost commented Aug 1, 2023

TODO - fix poetry installation in CI/CD

@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

1 similar comment
@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from abe51b5 to bdbae22 Compare August 1, 2023 16:20
@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from bdbae22 to 8b8c0aa Compare August 1, 2023 16:27
@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from 8b8c0aa to 5a74add Compare August 1, 2023 16:28
@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

@ghost ghost force-pushed the feat/kfp_v2 branch from 5a74add to 78755b3 Compare August 1, 2023 16:31
@ghost
Copy link
Author

ghost commented Aug 1, 2023

/gcbrun

@felix-datatonic
Copy link
Collaborator

/gcbrun

@ghost ghost merged commit 03863bc into develop Aug 5, 2023
@felix-datatonic felix-datatonic deleted the feat/kfp_v2 branch November 13, 2023 17:12
@felix-datatonic felix-datatonic mentioned this pull request Nov 15, 2023
Open
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felix-datatonic