Skip to content

Commit

Permalink
fix: update E2E tests for kfp v2
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonny Browning committed Jul 28, 2023
1 parent c744956 commit e2da6fe
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions pipelines/tests/e2e/test_e2e.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
# limitations under the License.

import logging
from typing import Callable

import pytest
import os
from google.cloud import storage
from kfp import compiler
from kfp.dsl import base_component

from pipelines.trigger.main import trigger_pipeline_from_payload

Expand Down Expand Up @@ -151,7 +151,7 @@ def test_batch_prediction_job_uri(


def pipeline_e2e_test(
pipeline_func: Callable,
pipeline_func: base_component.BaseComponent,
common_tasks: dict,
enable_caching: bool = None,
**kwargs: dict,
Expand All @@ -168,11 +168,11 @@ def pipeline_e2e_test(
**kwargs (dict): conditional tasks groups in dictionary
"""

pipeline_json = f"{pipeline_func.__name__}.json"
pipeline_yaml = f"{pipeline_func.name}.yaml"

compiler.Compiler().compile(
pipeline_func=pipeline_func,
package_path=pipeline_json,
package_path=pipeline_yaml,
type_check=False,
)

Expand All @@ -181,7 +181,7 @@ def pipeline_e2e_test(
enable_caching = None

payload = {
"attributes": {"template_path": pipeline_json, "enable_caching": enable_caching}
"attributes": {"template_path": pipeline_yaml, "enable_caching": enable_caching}
}

try:
Expand Down

0 comments on commit e2da6fe

Please sign in to comment.