Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify component imports #10

Merged
44 commits merged into from
May 17, 2023
Merged

Simplify component imports #10

44 commits merged into from
May 17, 2023

Conversation

felix-datatonic
Copy link
Collaborator

@felix-datatonic felix-datatonic commented May 9, 2023

Description

  • create python packages pipelines, aiplatform-components, bigquery-components where pipelines depend on the component packages
  • each package includes:
    • pyproject.toml
    • Pipfile
    • src folder with all package logic
    • tests folder for unit tests
  • pipelines package was modified with pipenv install -e ../aiplatform-components ../bigquery-components
    • this allows for code changes to reflect in this package without re-installing the dependent packages
  • update Makefile
    • sync assets optionally when running E2E tests (this aligns better with cloud build triggers)
    • setup-all-components installs aiplatform-components and bigquery-components
  • update cloud build triggers
    • use make commands where possible
  • update KFP version from 1.8.9 to 1.8.21

This removes the need to compile each component individually before compiling & running a pipeline.
As a result, the dev workflow has one less step and the overall compilation time locally and in cloud build reduces.
Further, this preserves isolation between each component group and pipelines.

How has this been tested?

  • make setup
  • make setup-components
  • make setup-all-components
  • make test-trigger
  • make compile-pipeline
  • make test-components
  • make test-all-components
  • make run
  • make e2e-tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

@felix-datatonic felix-datatonic changed the title Feature/simplify component imports Simplify component imports May 9, 2023
.pre-commit-config.yaml Outdated Show resolved Hide resolved
pipelines/src/pipelines/trigger/README.md Outdated Show resolved Hide resolved
pipelines/tests/e2e/test_e2e.py Outdated Show resolved Hide resolved
pipelines/src/pipelines/trigger/__main__.py Show resolved Hide resolved
pipelines/pyproject.toml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
aiplatform-components/tests/conftest.py Outdated Show resolved Hide resolved
bigquery-components/Pipfile Outdated Show resolved Hide resolved
bigquery-components/README.md Outdated Show resolved Hide resolved
pipelines/README.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
components/aiplatform-components/Pipfile Outdated Show resolved Hide resolved
components/aiplatform-components/pyproject.toml Outdated Show resolved Hide resolved
components/bigquery-components/README.md Outdated Show resolved Hide resolved
components/bigquery-components/tests/conftest.py Outdated Show resolved Hide resolved
pipelines/Pipfile Show resolved Hide resolved
@ghost
Copy link

ghost commented May 9, 2023

/gcbrun

@ghost ghost changed the base branch from main to develop May 17, 2023 12:59
@ghost ghost self-requested a review May 17, 2023 12:59
@ghost ghost merged commit 172d1c8 into develop May 17, 2023
@felix-datatonic felix-datatonic deleted the feature/simplify-component-imports branch November 13, 2023 17:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant