-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify component imports #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts' into feature/simplify-component-imports
felix-datatonic
changed the title
Feature/simplify component imports
Simplify component imports
May 9, 2023
ghost
suggested changes
May 9, 2023
ghost
suggested changes
May 9, 2023
/gcbrun |
ghost
approved these changes
May 17, 2023
6 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pipelines
,aiplatform-components
,bigquery-components
where pipelines depend on the component packagespyproject.toml
Pipfile
src
folder with all package logictests
folder for unit testspipenv install -e ../aiplatform-components ../bigquery-components
Makefile
setup-all-components
installs aiplatform-components and bigquery-componentsThis removes the need to compile each component individually before compiling & running a pipeline.
As a result, the dev workflow has one less step and the overall compilation time locally and in cloud build reduces.
Further, this preserves isolation between each component group and pipelines.
How has this been tested?
make setup
make setup-components
make setup-all-components
make test-trigger
make compile-pipeline
make test-components
make test-all-components
make run
make e2e-tests
Checklist
Pipeline run links: