Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix appengine import error #9323

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented May 4, 2023

Description of your changes:
Fixes ImportError when requests_toolbelt tries to import appengine from urllib3:

ImportError: cannot import name 'appengine' from 'urllib3.contrib'

Can be tested via the following Dockerfile and commands:

FROM python:3.7
RUN pip install --upgrade pip
RUN pip install 'git+https://github.com/connor-mccarthy/pipelines.git@fix-appengine-dependency-bug#subdirectory=sdk/python'
CMD [ "python", "-c", "import kfp; print(kfp.__version__)" ]
docker build . -t appengine-test && docker run appengine-test:latest

Checklist:

@connor-mccarthy connor-mccarthy requested a review from chensun May 4, 2023 17:20
@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@IronPan
Copy link
Member

IronPan commented May 4, 2023

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy connor-mccarthy marked this pull request as ready for review May 4, 2023 17:27
@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests e21f96f link false /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-prow google-oss-prow bot merged commit c437004 into kubeflow:master May 4, 2023
sergey-serebryakov added a commit to sergey-serebryakov/mlbox that referenced this pull request Dec 11, 2023
Updating version of the `kfp` dependency to 2.4.0. This fixes this error (kubeflow/pipelines#9323).
sergey-serebryakov added a commit to mlcommons/mlcube that referenced this pull request Dec 11, 2023
Updating version of the `kfp` dependency to 1.8.22. This fixes this error (kubeflow/pipelines#9323), and thus unit tests for the MLCube KubeFlow runner should now be passing. Can't use later versions since they use V2 API that will require code refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants