fix(Component): disable limit when fetching component data #8142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of missing versions in the component compare version picker by disabling the limit of number of logs fetched.
This is temporarily commented out until we merge the PR which enables lazy loading of component logs.
#7346
Currently, with this limit set - on a workspace; all sub routes of a component have only access to 3 logs from the component, which results in incorrect previous version selected when comparing an older tag/snap. It also fixes the issue where the version picker in Component Compare on a workspace will always only show the last three logs (snaps and tags)
On Cloud, we ignore the limit all together on the graphql server which results in correct behaviour