-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(Component UI): lazy load component logs #7346
Draft
luvkapur
wants to merge
26
commits into
master
Choose a base branch
from
ui/lazy-load-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,073
−719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odedre
reviewed
May 4, 2023
davidfirst
previously approved these changes
May 12, 2023
davidfirst
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Legacy Bit
loadComponentLogs
to accept a list of refs tostopAt
collectLogs
onModelComponent
to forwardstopAt
ref filter togetAllVersionsInfo
BIT
getLogs
onScopeMain
to allow filtering logs withhead?: string
startFrom?: string
stopAt?: string
startFromOffset?: number
stopAtOffset?: number
type?: 'snap' | 'tag'
findNodeByOffset
to find the closest node to an offset in a Version graphuntil
,startFrom
,head
,limit
,type (snap or tag)
UI
useComponentQuery
to allow lazy loading component logsuseComponentLogs
hookComponentCompare
fullScreen default modeLanesUI
refactorLanesSwitcher
fix loading stateCodeUI
allow overriding css for code snippets