Updates for ROS Noetic compatibility #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal. See ros/catkin#1052 Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]>
Uses catkin_install_python() so scripts are installed with the correct shebang for the given version of ROS. http://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 53 53
=========================================
Hits 53 53 Continue to review full report at Codecov.
|
tdenewiler
approved these changes
Sep 21, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to make this compatible with ROS Noetic. See the guide on Using Python 3 and the Noetic Migration Guide.
See https://answers.ros.org/question/361966/rosrun-still-use-python27-instead-of-38-inside-noetic
Bump CMake version to avoid CMP0048
This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.
See ros/catkin#1052
Use catkin_install_python
Uses catkin_install_python() so scripts are installed with the correct
shebang for the given version of ROS.
http://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs