111 remove public private switch #166
Conversation
| const today = new Date().toISOString().slice(0, 10).replace(/-/g, ''); | ||
|
|
||
| beforeEach(() => { | ||
| cy.loginUser(homeserverUrl, email, password); |
There was a problem hiding this comment.
J'ai fait une version de cy.loginUser sans arguments, pour eviter d'avoir a specifier les defaults. Dans cette PR : #171
(approuuuuuve ma PRRRRR, viennnnns 🐍 )
| @@ -35,6 +35,7 @@ getVar('E2E_TEST_USER_HOMESERVER_URL'); | |||
| getVar('E2E_TEST_USER_HOMESERVER_SHORT'); | |||
|
|
|||
| export default defineConfig({ | |||
| watchForFileChanges : false, | |||
There was a problem hiding this comment.
oui sinon, a chaque changement, il relance les tests c'est tres penible
|
|
||
| afterEach(() => { | ||
| // todo logout, otherwise the login test is not reliable aby more. | ||
| // todo delete room, otherwise the test user will end up with a million identical rooms after a while. |
There was a problem hiding this comment.
I have a PR to add this : #170
(apprrrouuuuuuuuuuuuuuve ma PRRRRRRRRR 🐍 😵💫)
| @@ -0,0 +1,51 @@ | |||
| import Chainable = Cypress.Chainable; | |||
|
|
|||
| export default class RoomUtils { | |||
There was a problem hiding this comment.
alternatively, you could use cy.createRoom (for better independence between tests) :
tchap-web-v4/cypress/support/client.ts
Lines 40 to 41 in ac8216a
But if it works, fine, let's move forward.
| //arrange | ||
| render(<TchapJoinRuleSettings {...props} />); | ||
|
|
||
| //assert that spaces option is not here while private and public are |
There was a problem hiding this comment.
public is asserted NOT there in the test. Is comment out of date ?
| }); | ||
|
|
||
|
|
||
| function openRoomAccessSettings(){ |
There was a problem hiding this comment.
on met ca dans les utils peut etre ? Chepa
| </>, | ||
| }]; */ | ||
|
|
||
| //tchap : we do not permit to change the type of room, thus display only one option |
There was a problem hiding this comment.
can you specify where tchap code ends, as well ? So that we know what's ours and what's not.
| /** | ||
| * TCHAP : disable space-related options if create space feature is not enabled | ||
| */ | ||
| if (ComponentVisibilityCustomisations.shouldShowComponent(UIComponent.CreateSpaces)) { |
There was a problem hiding this comment.
as we talked about, it would be better to create a separate flag, like showRooms or something
Co-authored-by: Estelle Comment <[email protected]>
Co-authored-by: Estelle Comment <[email protected]>
What have changed
Tests