Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Limitation] Tchap-web_v4 ignores the incoming room key requests until the cross-signing is supported #203

Closed
mcalinghee opened this issue Sep 23, 2022 · 1 comment · Fixed by #237
Assignees
Labels
bug Something isn't working key exchange P1 Priority 1 web

Comments

@mcalinghee
Copy link
Contributor

mcalinghee commented Sep 23, 2022

After having deactivating cross signing in Tartine, the client does not start the emoji device verification whenever another device requests key exchange.

with iphone

  • user has an Tartine session (no other sessions)
  • user starts iphone 2.0.5 session
  • iphone 2.0.5 requests keys from Tartine.
    → KO. emoji exchange does not start. Tartine seems to receive the event but does not treat it.

with android

  • user has an Tartine session (no other sessions)
  • user_1 se connecte a android
  • android doit demander les clefs à Tartine
    → KO. emoji exchange does not start. Tartine seems to receive the event but does not treat it.

with another web browser

  • user_1 est connecté Tartine
  • user_1 se connecte à Tartine sur un autre domain (https://app-v4.prod.tchap.incubateur.net/)
  • Tartine doit demander les clefs a Tartine
    → KO. emoji exchange does not start. Tartine seems to receive the event but does not treat it.

logs

In each case we have similar logs in Tartine console :
https://www.notion.so/mercurial-timer-ec4/5459adf85ac14e839c68592fa1c71764?v=c890e543e76b492583ebddda5fbe2670

@github-actions github-actions bot added the web label Sep 23, 2022
@mcalinghee mcalinghee added the bug Something isn't working label Sep 23, 2022
@odelcroi odelcroi added the P2 Priority 2 label Sep 26, 2022
@odelcroi odelcroi changed the title New iphone 2.0.5 session will not exchange keys with tartine Tartine does not start device verification with any device Sep 26, 2022
@odelcroi odelcroi changed the title Tartine does not start device verification with any device [Limitation] Tchap-web_v4 ignores the incoming room key requests until the cross-signing is supported Sep 26, 2022
@odelcroi
Copy link
Member

odelcroi commented Sep 26, 2022

KeyRequestHandler.js has been removed. One hint would be to revert it into the projet in order to open the missing dialog.

The dialog has been removed also : https://github.com/matrix-org/matrix-react-sdk/pull/4648/files#diff-a248ba2684dc92f20a3e2eba9f63e28a695f739a1736487a398f6380ba558cf6

EDIT : the dialog does not need to be backported, we should use an existing one : IncomingSasDialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working key exchange P1 Priority 1 web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants