Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reference data is emitted when calendarName = 'always' #3397

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

jessealama
Copy link
Contributor

Needed change to the polyfill will happen in a separate PR.

References:

@jessealama
Copy link
Contributor Author

cc @Ms2ger @ptomato

@jessealama
Copy link
Contributor Author

Polyfill change here.

@jessealama
Copy link
Contributor Author

(Unlike the proposal-temporal repo, I can't request a reviewer when making a PR.)

Ms2ger
Ms2ger previously approved these changes Feb 4, 2022
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once we get consensus

test/built-ins/Temporal/PlainMonthDay/calendar-always.js Outdated Show resolved Hide resolved
@rwaldron rwaldron added the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Feb 8, 2022
@ptomato
Copy link
Contributor

ptomato commented Feb 11, 2022

I think this may also require some updates to existing test262 tests.

@ptomato
Copy link
Contributor

ptomato commented Feb 17, 2022

For the record, these tests are related to tc39/proposal-temporal#2035 which is a normative change to the Temporal proposal that I plan to present for consensus at the March TC39 meeting.

I think this may also require some updates to existing test262 tests.

What I meant by this - I believe the following existing tests (and possibly others?) might start to fail if implementations start following that normative change, so I think they should be adapted before this PR can be considered complete.

  • built-ins/Temporal/PlainMonthDay/prototype/toString/calendarname-always.js
  • built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-always.js

@jessealama jessealama marked this pull request as ready for review February 21, 2022 12:56
@jessealama
Copy link
Contributor Author

For the record, these tests are related to tc39/proposal-temporal#2035 which is a normative change to the Temporal proposal that I plan to present for consensus at the March TC39 meeting.

I think this may also require some updates to existing test262 tests.

What I meant by this - I believe the following existing tests (and possibly others?) might start to fail if implementations start following that normative change, so I think they should be adapted before this PR can be considered complete.

* built-ins/Temporal/PlainMonthDay/prototype/toString/calendarname-always.js

* built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-always.js

Good catch -- I've updated both of these.

@ptomato ptomato removed the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Mar 29, 2022
@ptomato
Copy link
Contributor

ptomato commented Mar 29, 2022

The corresponding normative change achieved consensus, so I'll merge this.

@ptomato ptomato merged commit fe40aea into tc39:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants