-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure reference data is emitted when calendarName = 'always' #3397
Conversation
Polyfill change here. |
(Unlike the proposal-temporal repo, I can't request a reviewer when making a PR.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once we get consensus
cf7a2a4
to
9452778
Compare
I think this may also require some updates to existing test262 tests. |
For the record, these tests are related to tc39/proposal-temporal#2035 which is a normative change to the Temporal proposal that I plan to present for consensus at the March TC39 meeting.
What I meant by this - I believe the following existing tests (and possibly others?) might start to fail if implementations start following that normative change, so I think they should be adapted before this PR can be considered complete.
|
Good catch -- I've updated both of these. |
The corresponding normative change achieved consensus, so I'll merge this. |
Needed change to the polyfill will happen in a separate PR.
References: