Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Emit reference information when calendarName = 'always' #2035

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

jessealama
Copy link
Collaborator

closes #1971

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #2035 (9a356cb) into main (6cf421b) will decrease coverage by 4.39%.
The diff coverage is 100.00%.

❗ Current head 9a356cb differs from pull request most recent head 32bf5d3. Consider uploading reports for the commit 32bf5d3 to get more accurate results

@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   92.19%   87.80%   -4.40%     
==========================================
  Files          19       17       -2     
  Lines       10928    10992      +64     
  Branches     1571     1433     -138     
==========================================
- Hits        10075     9651     -424     
- Misses        835     1322     +487     
- Partials       18       19       +1     
Flag Coverage Δ
test262 ?
tests 87.28% <100.00%> (+3.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/ecmascript.mjs 92.42% <100.00%> (-3.45%) ⬇️
polyfill/lib/plainyearmonth.mjs 26.04% <0.00%> (-41.32%) ⬇️
polyfill/lib/plainmonthday.mjs 51.06% <0.00%> (-31.92%) ⬇️
polyfill/lib/plaindate.mjs 63.56% <0.00%> (-20.68%) ⬇️
polyfill/lib/instant.mjs 84.79% <0.00%> (-9.46%) ⬇️
polyfill/lib/now.mjs 91.22% <0.00%> (-8.78%) ⬇️
polyfill/lib/timezone.mjs 85.35% <0.00%> (-8.29%) ⬇️
polyfill/lib/zoneddatetime.mjs 91.28% <0.00%> (-7.23%) ⬇️
polyfill/lib/intrinsicclass.mjs 52.70% <0.00%> (-2.71%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf421b...32bf5d3. Read the comment docs.

@ptomato ptomato changed the title Emit reference information when calendarName = 'always' Normative: Emit reference information when calendarName = 'always' Feb 4, 2022
@ptomato
Copy link
Collaborator

ptomato commented Feb 4, 2022

This needs a corresponding change in the spec text.

@ptomato ptomato added needs plenary input Needs to be presented to the committee and feedback incorporated spec-text Specification text involved labels Feb 5, 2022
@jessealama
Copy link
Collaborator Author

updated spec text

spec/plainmonthday.html Outdated Show resolved Hide resolved
spec/plainyearmonth.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Will keep this marked as a draft until presented at TC39.

@ptomato ptomato marked this pull request as ready for review March 29, 2022 23:56
@ptomato
Copy link
Collaborator

ptomato commented Mar 29, 2022

This achieved consensus at the March 2022 TC39 plenary meeting.

@ptomato ptomato force-pushed the calendar-name-always-full-ymd branch from d965615 to 32bf5d3 Compare March 30, 2022 00:02
@ptomato ptomato merged commit 4f7519a into tc39:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs plenary input Needs to be presented to the committee and feedback incorporated spec-text Specification text involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YYYY-MM[u-ca=iso8601] and MM-DD[u-ca=iso8601] formats are not round-trippable
2 participants