Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default calendar #991

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Default calendar #991

merged 6 commits into from
Oct 14, 2020

Commits on Oct 14, 2020

  1. Remove redundant test 

    This exact same thing is also tested in test/now.mjs.
    @ptomato
    ptomato committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    57b6d7b View commit details
    Browse the repository at this point in the history

  2. Rename Temporal.now.time() to Temporal.now.timeISO() 

    In the absence of time calendars (#522) we cannot yet have a
Temporal.now.time() method that requires a calendar, so just remove it,
effectively renaming it to the new Temporal.now.timeISO() method.

See: #292
    @ptomato
    ptomato committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    7d42d80 View commit details
    Browse the repository at this point in the history

  3. Make calendar required in Temporal.now.dateTime() and Temporal.now.da… 

    …te()

This also requires switching the order of the arguments so that the
calendar comes before the time zone, which is still optional.

See: #292
    @ptomato
    ptomato committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    883ed79 View commit details
    Browse the repository at this point in the history

  4. Add Temporal.now.dateTimeISO() and Temporal.now.dateISO() 

    Convenience methods that give the current date and datetime in the ISO
8601 calendar.

See: #292
    @ptomato
    ptomato committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    c976eae View commit details
    Browse the repository at this point in the history

  5. Make calendar required in Instant.toDateTime() 

    See: #292
    @ptomato
    ptomato committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    3e7701d View commit details
    Browse the repository at this point in the history

  6. Add Instant.toDateTimeISO() 

    Convenience method that does the conversion in the ISO 8601 calendar. Also
adds Instant.toZonedDateTimeISO() to the documentation, even though it is
not implemented yet.

See: #292
    @ptomato
    ptomato committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    7dc0a53 View commit details
    Browse the repository at this point in the history