Default calendar #991

ptomato · 2020-10-14T21:14:26Z

Closes: #292

This exact same thing is also tested in test/now.mjs.

In the absence of time calendars (#522) we cannot yet have a Temporal.now.time() method that requires a calendar, so just remove it, effectively renaming it to the new Temporal.now.timeISO() method. See: #292

…te() This also requires switching the order of the arguments so that the calendar comes before the time zone, which is still optional. See: #292

Convenience methods that give the current date and datetime in the ISO 8601 calendar. See: #292

See: #292

Convenience method that does the conversion in the ISO 8601 calendar. Also adds Instant.toZonedDateTimeISO() to the documentation, even though it is not implemented yet. See: #292

codecov · 2020-10-14T21:15:04Z

Codecov Report

Merging #991 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   94.34%   94.37%   +0.03%     
==========================================
  Files          18       18              
  Lines        6222     6239      +17     
  Branches      914      916       +2     
==========================================
+ Hits         5870     5888      +18     
+ Misses        345      344       -1     
  Partials        7        7

Flag	Coverage Δ
#test262	`46.72% <37.50%> (-0.06%)`	⬇️
#tests	`90.22% <95.83%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
polyfill/lib/instant.mjs	`97.39% <100.00%> (+0.05%)`	⬆️
polyfill/lib/now.mjs	`100.00% <100.00%> (ø)`
polyfill/lib/ecmascript.mjs	`95.74% <0.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b16e0...7dc0a53. Read the comment docs.

sffc

Looks great; thanks!

ptomato added 6 commits October 14, 2020 14:11

Remove redundant test

57b6d7b

This exact same thing is also tested in test/now.mjs.

Rename Temporal.now.time() to Temporal.now.timeISO()

7d42d80

In the absence of time calendars (#522) we cannot yet have a Temporal.now.time() method that requires a calendar, so just remove it, effectively renaming it to the new Temporal.now.timeISO() method. See: #292

Make calendar required in Temporal.now.dateTime() and Temporal.now.da…

883ed79

…te() This also requires switching the order of the arguments so that the calendar comes before the time zone, which is still optional. See: #292

Add Temporal.now.dateTimeISO() and Temporal.now.dateISO()

c976eae

Convenience methods that give the current date and datetime in the ISO 8601 calendar. See: #292

Make calendar required in Instant.toDateTime()

3e7701d

See: #292

Add Instant.toDateTimeISO()

7dc0a53

Convenience method that does the conversion in the ISO 8601 calendar. Also adds Instant.toZonedDateTimeISO() to the documentation, even though it is not implemented yet. See: #292

ptomato requested review from Ms2ger, justingrant, pipobscure, jasonwilliams, sffc, gibson042, mattjohnsonpint and ryzokuken October 14, 2020 21:14

sffc approved these changes Oct 14, 2020

View reviewed changes

ptomato merged commit 896d4f5 into main Oct 14, 2020

ptomato deleted the 292-default-calendar branch October 14, 2020 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default calendar #991

Default calendar #991

ptomato commented Oct 14, 2020

codecov bot commented Oct 14, 2020 •

edited

Loading

sffc left a comment

Default calendar #991

Default calendar #991

Conversation

ptomato commented Oct 14, 2020

codecov bot commented Oct 14, 2020 • edited Loading

Codecov Report

sffc left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 14, 2020 •

edited

Loading