Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: refactor TimeZone [[OffsetNanoseconds]] internal slot to [[OffsetMinutes]] #2622

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Editorial: refactor TimeZone [[OffsetNanoseconds]] internal slot to [[OffsetMinutes]] #2622

merged 1 commit into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. Editorial: rename TimeZone nanoseconds slot/AOs 

    Now that we've limited TimeZone's [[OffsetNanoseconds]] internal slot
to minute precision, this commit refactors TimeZone to clarify that only
minutes are allowed in that slot and related abstract operations.

Changes:
* Renames TimeZone's [[OffsetNanoseconds]] internal slot to
  [[OffsetMinutes]]
* Changes ParseTimeZoneIdentifier to return an [[OffsetMinutes]] field
  instead of an [[OffsetNanoseconds]] field.
* Changes FormatOffsetTimeZoneIdentifier to expect a minutes argument.

The goal of this change is to avoid the complexity and potential
confusion from a slot and AOs that deal with "nanoseconds" values
that nonetheless are restricted to minutes.
    @justingrant
    justingrant committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    890327c View commit details
    Browse the repository at this point in the history