-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: refactor TimeZone [[OffsetNanoseconds]] internal slot to [[OffsetMinutes]] #2622
Editorial: refactor TimeZone [[OffsetNanoseconds]] internal slot to [[OffsetMinutes]] #2622
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2622 +/- ##
==========================================
- Coverage 95.96% 95.94% -0.02%
==========================================
Files 20 20
Lines 11528 11550 +22
Branches 2193 2197 +4
==========================================
+ Hits 11063 11082 +19
- Misses 401 404 +3
Partials 64 64
|
6a57343
to
49ecd37
Compare
In today's TG2 meeting, there was confusion from folks who saw the Anyway, that meeting cemented my opinion that we should make this renaming editorial change, because it makes the allowed precision clearer for spec readers or reviewers who aren't as familiar with the rest of Temporal. |
4bf9fad
to
100118a
Compare
2d76d40
to
d3c20e7
Compare
d3c20e7
to
5eca86f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still prefer keeping everything in nanoseconds, but I understand the motivation here.
5e6de69
to
4ed1f37
Compare
Now that we've limited TimeZone's [[OffsetNanoseconds]] internal slot to minute precision, this commit refactors TimeZone to clarify that only minutes are allowed in that slot and related abstract operations. Changes: * Renames TimeZone's [[OffsetNanoseconds]] internal slot to [[OffsetMinutes]] * Changes ParseTimeZoneIdentifier to return an [[OffsetMinutes]] field instead of an [[OffsetNanoseconds]] field. * Changes FormatOffsetTimeZoneIdentifier to expect a minutes argument. The goal of this change is to avoid the complexity and potential confusion from a slot and AOs that deal with "nanoseconds" values that nonetheless are restricted to minutes.
4ed1f37
to
890327c
Compare
Implements the changes from: - tc39/proposal-temporal#2621 - tc39/proposal-temporal#2622 - tc39/proposal-temporal#2632 - tc39/proposal-temporal#2607 Differential Revision: https://phabricator.services.mozilla.com/D185412
Implements the changes from: - tc39/proposal-temporal#2621 - tc39/proposal-temporal#2622 - tc39/proposal-temporal#2632 - tc39/proposal-temporal#2607 Differential Revision: https://phabricator.services.mozilla.com/D185412
This PR is stacked on #2607. Please review only the last commit. At @ptomato's request, I'm splitting it into a separate editorial PR to simplify review of the other normative PR. It's marked as a draft until #2607 is approved at the upcoming TC39 meeting.
Now that #2607 limits TimeZone's [[OffsetNanoseconds]] internal slot to minute precision, this PR refactors TimeZone to clarify that only minutes are allowed in that slot and related abstract operations.
Changes:
The goal of this change is to avoid the complexity and potential confusion from a slot and AOs that deal with "nanoseconds" values that nonetheless are restricted to minutes.