Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Throw TypeError on missing options from Duration.total #1720

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Aug 12, 2021

See also #1646, #1640

@ptomato ptomato requested a review from Ms2ger August 12, 2021 23:45
@ptomato ptomato force-pushed the duration-total-missing-unit branch from 2124492 to 9ad1ee2 Compare August 12, 2021 23:50
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1720 (6abfcf1) into main (00c28d2) will decrease coverage by 22.13%.
The diff coverage is 100.00%.

❗ Current head 6abfcf1 differs from pull request most recent head 9ad1ee2. Consider uploading reports for the commit 9ad1ee2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1720       +/-   ##
===========================================
- Coverage   95.03%   72.89%   -22.14%     
===========================================
  Files          19       18        -1     
  Lines       10785     4841     -5944     
  Branches     1725     1059      -666     
===========================================
- Hits        10249     3529     -6720     
- Misses        523     1030      +507     
- Partials       13      282      +269     
Flag Coverage Δ
test262 72.89% <100.00%> (+<0.01%) ⬆️
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/duration.mjs 90.43% <100.00%> (-7.65%) ⬇️
polyfill/lib/calendar.mjs 23.22% <0.00%> (-71.15%) ⬇️
polyfill/lib/intl.mjs 67.46% <0.00%> (-32.54%) ⬇️
polyfill/lib/instant.mjs 79.13% <0.00%> (-15.31%) ⬇️
polyfill/lib/plainmonthday.mjs 79.01% <0.00%> (-14.14%) ⬇️
polyfill/lib/plainyearmonth.mjs 83.42% <0.00%> (-12.99%) ⬇️
polyfill/lib/ecmascript.mjs 82.79% <0.00%> (-12.28%) ⬇️
polyfill/lib/plaindatetime.mjs 85.14% <0.00%> (-12.17%) ⬇️
polyfill/lib/timezone.mjs 81.66% <0.00%> (-11.80%) ⬇️
polyfill/lib/zoneddatetime.mjs 89.41% <0.00%> (-8.99%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c28d2...9ad1ee2. Read the comment docs.

@ptomato
Copy link
Collaborator Author

ptomato commented Aug 13, 2021

Normative pull request -> draft

@ptomato
Copy link
Collaborator Author

ptomato commented Aug 31, 2021

This change achieved consensus in TC39.

@Ms2ger Would you mind taking a final look?

@Ms2ger Ms2ger merged commit 85dca28 into main Sep 2, 2021
@Ms2ger Ms2ger deleted the duration-total-missing-unit branch September 2, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants