Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Throw TypeError in Instant.round if options is undefined #1646

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

FrankYFTang
Copy link
Contributor

Make the Instant.prototype.round() throw also TypeError instead of RangeError if options is undefined.
See #1639 (comment)

@justingrant @ptomato @Ms2ger @ryzokuken

Make the Instant.prototype.round() throw also TypeError instead of RangeError if options is undefined.
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #1646 (b893acd) into main (b77da58) will decrease coverage by 22.17%.
The diff coverage is n/a.

❗ Current head b893acd differs from pull request most recent head 17c1c1f. Consider uploading reports for the commit 17c1c1f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1646       +/-   ##
===========================================
- Coverage   95.00%   72.82%   -22.18%     
===========================================
  Files          19       18        -1     
  Lines       10726     4814     -5912     
  Branches     1716     1052      -664     
===========================================
- Hits        10190     3506     -6684     
- Misses        523     1029      +506     
- Partials       13      279      +266     
Flag Coverage Δ
test262 72.82% <ø> (+0.02%) ⬆️
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/calendar.mjs 23.22% <0.00%> (-71.15%) ⬇️
polyfill/lib/intl.mjs 64.86% <0.00%> (-35.14%) ⬇️
polyfill/lib/instant.mjs 79.85% <0.00%> (-14.59%) ⬇️
polyfill/lib/plainmonthday.mjs 79.01% <0.00%> (-14.14%) ⬇️
polyfill/lib/plainyearmonth.mjs 83.42% <0.00%> (-12.99%) ⬇️
polyfill/lib/ecmascript.mjs 82.79% <0.00%> (-12.28%) ⬇️
polyfill/lib/plaindatetime.mjs 85.14% <0.00%> (-12.17%) ⬇️
polyfill/lib/timezone.mjs 81.66% <0.00%> (-11.80%) ⬇️
polyfill/lib/zoneddatetime.mjs 89.41% <0.00%> (-8.99%) ⬇️
polyfill/lib/duration.mjs 90.38% <0.00%> (-7.70%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77da58...17c1c1f. Read the comment docs.

@Ms2ger Ms2ger changed the title Throw TypeError in Instant.round if options is und Normative: Throw TypeError in Instant.round if options is undefined Jul 15, 2021
Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FrankYFTang
Copy link
Contributor Author

@ptomato your link on https://ptomato.name/talks/tc39-2021-08/#22 pointing here is wrong w/ an extra 's' after pull

@ptomato
Copy link
Collaborator

ptomato commented Aug 25, 2021

Thanks, fixed.

@ptomato ptomato marked this pull request as ready for review August 31, 2021 18:59
@ptomato
Copy link
Collaborator

ptomato commented Aug 31, 2021

This change achieved consensus in TC39.

@ptomato ptomato merged commit 5653bc7 into tc39:main Aug 31, 2021
@FrankYFTang FrankYFTang deleted the patch-17 branch September 16, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants