-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Throw TypeError in Instant.round if options is undefined #1646
Conversation
Make the Instant.prototype.round() throw also TypeError instead of RangeError if options is undefined.
Codecov Report
@@ Coverage Diff @@
## main #1646 +/- ##
===========================================
- Coverage 95.00% 72.82% -22.18%
===========================================
Files 19 18 -1
Lines 10726 4814 -5912
Branches 1716 1052 -664
===========================================
- Hits 10190 3506 -6684
- Misses 523 1029 +506
- Partials 13 279 +266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ptomato your link on https://ptomato.name/talks/tc39-2021-08/#22 pointing here is wrong w/ an extra 's' after pull |
Thanks, fixed. |
This change achieved consensus in TC39. |
Make the Instant.prototype.round() throw also TypeError instead of RangeError if options is undefined.
See #1639 (comment)
@justingrant @ptomato @Ms2ger @ryzokuken