Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time calendars #1188

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Remove time calendars #1188

merged 3 commits into from
Nov 16, 2020

Commits on Nov 16, 2020

  1. Remove time calendars

    - Remove Calendar.timeFromFields(), Calendar.timeAdd(),
      Calendar.timeUntil(), Calendar.hour(), ..., Calendar.nanosecond().
    - Remove PlainTime.withCalendar().
    - Remove now.plainTime().
    - Remove the calendar argument from PlainTime constructor.
    - Remove the calendarName option from PlainTime.toString().
    - Throw if there's a non-ISO calendar passed to PlainTime.from().
    - The value of PlainTime.calendar is always the ISO calendar.
    - Leave the names of the slots, the properties returned from
      PlainTime.getFields() and PlainTime.getISOFields().
    
    See: #522
    ptomato committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    edf994d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e09e5ec View commit details
    Browse the repository at this point in the history
  3. Fix overflow affecting invalid ISO string

    It was decided in #260 that overflow: 'constrain' should not affect
    invalid values coming from ISO strings, but it seems that it crept back in
    during a refactor. Fix this and add a test so that it doesn't regress
    again.
    ptomato committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    e3e40b6 View commit details
    Browse the repository at this point in the history