Remove time calendars #1188
Merged
Remove time calendars #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
+ Coverage 93.55% 95.72% +2.17%
==========================================
Files 19 19
Lines 7961 9175 +1214
Branches 1264 1384 +120
==========================================
+ Hits 7448 8783 +1335
+ Misses 506 386 -120
+ Partials 7 6 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ptomato
force-pushed
the
522-remove-time-calendars
branch
from
7c2b51d
to
b703589
Compare
Ms2ger
previously requested changes
Nov 16, 2020
ptomato
force-pushed
the
522-remove-time-calendars
branch
from
b703589
to
c5c507f
Compare
littledan
approved these changes
Nov 16, 2020
ptomato
force-pushed
the
522-remove-time-calendars
branch
from
c5c507f
to
9fc3bf1
Compare
- Remove Calendar.timeFromFields(), Calendar.timeAdd(), Calendar.timeUntil(), Calendar.hour(), ..., Calendar.nanosecond(). - Remove PlainTime.withCalendar(). - Remove now.plainTime(). - Remove the calendar argument from PlainTime constructor. - Remove the calendarName option from PlainTime.toString(). - Throw if there's a non-ISO calendar passed to PlainTime.from(). - The value of PlainTime.calendar is always the ISO calendar. - Leave the names of the slots, the properties returned from PlainTime.getFields() and PlainTime.getISOFields(). See: #522
It was decided in #260 that overflow: 'constrain' should not affect invalid values coming from ISO strings, but it seems that it crept back in during a refactor. Fix this and add a test so that it doesn't regress again.
ptomato
force-pushed
the
522-remove-time-calendars
branch
from
9fc3bf1
to
e3e40b6
Compare
|
I have addressed the comments, so landing this now; if there are further comments please let me know and I'll follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #522