Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Instant.toDateTime{,ISO}(), DateTime.toInstant() #1088

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Remove Instant.toDateTime{,ISO}(), DateTime.toInstant() #1088

merged 3 commits into from
Nov 2, 2020

Commits on Nov 2, 2020

  1. Remove Instant.toDateTime{,ISO}(), DateTime.toInstant() 

    These conversions are redundant, they either go through ZonedDateTime or
TimeZone.

Cookbook examples that used these conversions are changed, where possible,
to use ZonedDateTime. Where that is not possible because of unimplemented
ZonedDateTime methods, we add a FIXME note and fall back to the more
verbose TimeZone conversion methods.

Updating some of the cookbook examples is taken from #700.

Co-authored-by: Justin Grant <[email protected]>

Closes: #1026
    @ptomato
    ptomato committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    0129d4f View commit details
    Browse the repository at this point in the history

  2. Update docs/cookbook/getParseableZonedStringWithLocalTimeInOtherZone.mjs 

    Co-authored-by: Justin Grant <[email protected]>
    @Ms2ger @justingrant
    Ms2ger and justingrant authored Nov 2, 2020
    Configuration menu
    Copy the full SHA
    a8906b8 View commit details
    Browse the repository at this point in the history

  3. Update getParseableZonedStringWithLocalTimeInOtherZone.mjs

    @Ms2ger
    Ms2ger authored Nov 2, 2020
    Configuration menu
    Copy the full SHA
    9b182c5 View commit details
    Browse the repository at this point in the history