Remove Instant.toDateTime{,ISO}(), DateTime.toInstant() #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042 and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 93.59% 93.55% -0.05%
==========================================
Files 19 19
Lines 7702 7683 -19
Branches 1224 1221 -3
==========================================
- Hits 7209 7188 -21
- Misses 486 488 +2
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
These conversions are redundant, they either go through ZonedDateTime or TimeZone. Cookbook examples that used these conversions are changed, where possible, to use ZonedDateTime. Where that is not possible because of unimplemented ZonedDateTime methods, we add a FIXME note and fall back to the more verbose TimeZone conversion methods. Updating some of the cookbook examples is taken from #700. Co-authored-by: Justin Grant <[email protected]> Closes: #1026
justingrant
reviewed
Nov 2, 2020
ptomato
force-pushed
the
1026-remove-instant-plaindatetime-conversion
branch
from
6f5ac9c
to
0129d4f
Compare
justingrant
approved these changes
Nov 2, 2020
docs/cookbook/getParseableZonedStringWithLocalTimeInOtherZone.mjs
Outdated
Show resolved
Hide resolved
Ms2ger
approved these changes
Nov 2, 2020
|
Travis is having issues, so I tested locally before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These conversions are redundant, they either go through ZonedDateTime or
TimeZone.
Cookbook examples that used these conversions are changed, where possible,
to use ZonedDateTime. Where that is not possible because of unimplemented
ZonedDateTime methods, we add a FIXME note and fall back to the more
verbose TimeZone conversion methods.
Updating some of the cookbook examples is taken from #700.
Closes: #1026