Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: misc minor editorial changes #2909

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Editorial: misc minor editorial changes #2909

merged 1 commit into from
Sep 21, 2022

Conversation

michaelficarra
Copy link
Member

Extracted from #2877.

@michaelficarra michaelficarra requested a review from a team September 16, 2022 21:28
jmdyck
jmdyck reviewed Sep 17, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@michaelficarra
Copy link
Member Author

@jmdyck Thanks for the review. Comments should be addressed.

bakkot
bakkot approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this includes a use of the new interval notation which is introduced by #2848, and so should probably land after that PR.

@michaelficarra
Copy link
Member Author

@bakkot I backed it out since it was already included there.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Sep 20, 2022
@ljharb ljharb merged commit 1f67a0d into main Sep 21, 2022
@ljharb ljharb deleted the misc-editorial branch September 21, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdyck jmdyck jmdyck left review comments

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelficarra @bakkot @jmdyck @ljharb