New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: consistency in phrasing of ranges and inclusivity/exclusivity #2848

Merged

ljharb merged 2 commits into main from inclusive-range

Sep 27, 2022

Member

michaelficarra commented Aug 6, 2022

I chose to use "within the inclusive range from A to B" or use chained comparisons where possible. For ranges that have an open end, I name each side as either exclusive or inclusive.

michaelficarra requested a review from a team

August 6, 2022 00:03

michaelficarra mentioned this pull request

Normative: Use DefaultTimeZone to get the local time zone for Date #2781

Merged

ljharb reviewed

View reviewed changes

Member

ljharb left a comment

This is a great improvement. Another option tho would be to use [a, b)-style notation throughout - that way it'd be unambiguous which sides were inclusive or exclusive, and all permutations could be represented. Any reason not to prefer that?

spec.html Show resolved Hide resolved

spec.html Outdated Show resolved Hide resolved

spec.html Outdated Show resolved Hide resolved

ljharb added the editorial change label

Member Author

michaelficarra commented Aug 8, 2022

Thoughts on using the term "interval" instead of "range"? What about using (and explaining) the standard interval notation from maths? Any considerations for using this form for both floats and mathematical values?

Member

ljharb commented Aug 8, 2022

I think defining and using interval notation would be much less ambiguous than prose.

Member Author

michaelficarra commented Aug 9, 2022

Updated with far more rigour and renamed ranges to intervals.

michaelficarra force-pushed the inclusive-range branch from 9de5955 to 06d273e Compare

August 9, 2022 00:11

bakkot reviewed

View reviewed changes

spec.html Show resolved Hide resolved

bakkot reviewed

View reviewed changes

spec.html Show resolved Hide resolved

bakkot added the establishes editorial conventions label

michaelficarra added editor call and removed editor call labels

michaelficarra force-pushed the inclusive-range branch from fb8936a to 2190bf1 Compare

August 11, 2022 00:07

Member

ljharb commented Aug 11, 2022

@michaelficarra was the decision not to use (a, b] notation?

Member Author

michaelficarra commented Aug 11, 2022

@ljharb We did not discuss that today in the editor call, but both @bakkot and I prefer this form to the interval notation, so I'm going to stick with it.

michaelficarra requested a review from bakkot

August 11, 2022 01:35

bakkot reviewed

View reviewed changes

spec.html Show resolved Hide resolved

michaelficarra requested review from a team and bakkot

August 12, 2022 18:13

ljharb reviewed

View reviewed changes

spec.html Outdated Show resolved Hide resolved

bakkot reviewed

View reviewed changes

spec.html Show resolved Hide resolved

bakkot reviewed

View reviewed changes

spec.html Outdated Show resolved Hide resolved

spec.html Outdated

    
            @@ -1760,17 +1761,17 @@ <h1>The Number Type</h1>
          
                      <div class="math-display">

                        _s_ &times; _m_ &times; 2<sup>_e_</sup>

                      </div>

                      <p>where _s_ is 1 or -1, _m_ is an integer such that 2<sup>52</sup> &le; _m_ &lt; 2<sup>53</sup>, and _e_ is an integer such that -1074 &le; _e_ &le; 971.</p>

                      <p>where _s_ is 1 or -1, _m_ is an integer in the interval from 2<sup>52</sup> (inclusive) to 2<sup>53</sup> (exclusive), and _e_ is an integer in the inclusive interval from -1074 to 971.</p>

Contributor

bakkot Aug 16, 2022

This one really doesn't seem like an improvement.

spec.html Outdated Show resolved Hide resolved

spec.html Outdated Show resolved Hide resolved

michaelficarra force-pushed the inclusive-range branch from 8112921 to 19bd4f6 Compare

August 16, 2022 15:02

bakkot requested changes

View reviewed changes

spec.html Show resolved Hide resolved

michaelficarra requested review from bakkot and a team

August 24, 2022 17:22

michaelficarra added the editor call label

syg reviewed

View reviewed changes

spec.html Show resolved Hide resolved

ljharb reviewed

View reviewed changes

spec.html Outdated Show resolved Hide resolved

michaelficarra removed the editor call label

Member Author

michaelficarra commented Aug 25, 2022

I noticed this weird ecmarkup rendering issue, so we may want to hold off merging until it is fixed.

Ping @bakkot if you want to open an ecmarkup issue with a repro case. I'm guessing it has to do with the HTML comment?

michaelficarra requested a review from syg

August 25, 2022 00:04

bakkot reviewed

View reviewed changes

spec.html Outdated Show resolved Hide resolved

bakkot reviewed

View reviewed changes

spec.html Outdated Show resolved Hide resolved

michaelficarra force-pushed the inclusive-range branch from e5d24da to 4bc999d Compare

August 30, 2022 04:47

bakkot approved these changes

View reviewed changes

Contributor

bakkot left a comment

LGTM except

I am not a fan of the DecimalDigit change, though I am not going to die on that hill
needs the just-published ecmarkup v14.1.2 to be upstreamed to fix the rendering issue before this lands (possibly as part of this PR)

Member Author

michaelficarra commented Aug 30, 2022

michaelficarra force-pushed the inclusive-range branch from 4d19097 to e1fd6c7 Compare

August 30, 2022 16:09

bakkot added the editor call label

michaelficarra force-pushed the inclusive-range branch from e1fd6c7 to a61e503 Compare

September 20, 2022 21:30

syg approved these changes

View reviewed changes

spec.html Outdated Show resolved Hide resolved

ptomato mentioned this pull request

Editorial: Simplify ISO calendar operations tc39/proposal-temporal#2408

Merged

michaelficarra force-pushed the inclusive-range branch from a61e503 to 557128e Compare

September 27, 2022 01:46

michaelficarra added ready to merge and removed editor call labels

michaelficarra added 2 commits

September 26, 2022 18:50


          Editorial: consistency in phrasing of ranges and inclusivity/exclusiv…

fdf0aad

…ity (#2848)


          Meta: update ecmarkup (#2848)

2600c07

ljharb force-pushed the inclusive-range branch from 557128e to 2600c07 Compare

September 27, 2022 01:51

ljharb merged commit 2600c07 into main

ljharb deleted the inclusive-range branch

September 27, 2022 01:54

jmdyck added a commit to jmdyck/ecma262 that referenced this pull request


          Editorial: Define alias before reference

79f12f5

String.prototype.lastIndexOf must define _searchLen_ before using it.

(fixup for PR tc39#2848)

jmdyck mentioned this pull request

Editorial: Define alias before reference #2916

Merged

ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request


          Editorial: Define alias before reference (tc39#2916)

231f270

String.prototype.lastIndexOf must define _searchLen_ before using it.

(fixup for PR tc39#2848)

bakkot mentioned this pull request

expr-parser: "for some" counts as a declaration tc39/ecmarkup#496

Merged

ptomato mentioned this pull request

Date time operations cleanup Aditi-1400/ecma262#1

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial change establishes editorial conventions ready to merge