Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: eval(nonString) should not have observable side effects #1504

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Normative: eval(nonString) should not have observable side effects #1504

merged 1 commit into from
Jun 4, 2019

Commits on Jun 4, 2019

  1. Normative: eval(nonString) should not have observable side effects (#… 

    …1504)

Fixes #1495
which identifies the ordering of host callouts and input type checks as a spec bug.

This uses option 1 from #1495 (comment)
to ensure that type checks happen before host callouts.

This can't be tested in test262 but if this lands, I will follow up with tests via web-platform-tests/wpt.
    @mikesamuel @ljharb
    mikesamuel authored and ljharb committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    a25df66 View commit details
    Browse the repository at this point in the history