Normative: eval(nonString) should not have observable side effects
#1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
needs consensus
mikesamuel
added a commit
to mikesamuel/wpt
that referenced
this pull request
Apr 9, 2019
This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away.
zenparsing
reviewed
Apr 9, 2019
That's not correct. See 12.3.4.1 step 6.a. %eval% is a reference to the |
jugglinmike
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 11, 2019
* [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands.
|
Maybe @domenic can help clarify, as I believe he wrote much of this specification text. |
domenic
reviewed
Jun 4, 2019
ljharb
added
has consensus
ljharb
approved these changes
Jun 4, 2019
zenparsing
approved these changes
Jun 4, 2019
…1504) Fixes #1495 which identifies the ordering of host callouts and input type checks as a spec bug. This uses option 1 from #1495 (comment) to ensure that type checks happen before host callouts. This can't be tested in test262 but if this lands, I will follow up with tests via web-platform-tests/wpt.
ljharb
changed the title
eval(nonString) should not have observable side effects
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 5, 2019
…eck during eval, a=testonly Automatic update from web-platform-tests [csp] test order of host callout & typecheck during eval (#16301) * [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands. -- wpt-commits: e3d0146264093a389148cc555ee9be69bd75719b wpt-pr: 16301
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jun 6, 2019
…eck during eval, a=testonly Automatic update from web-platform-tests [csp] test order of host callout & typecheck during eval (#16301) * [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands. -- wpt-commits: e3d0146264093a389148cc555ee9be69bd75719b wpt-pr: 16301
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
* [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…eck during eval, a=testonly Automatic update from web-platform-tests [csp] test order of host callout & typecheck during eval (#16301) * [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands. -- wpt-commits: e3d0146264093a389148cc555ee9be69bd75719b wpt-pr: 16301 UltraBlame original commit: 88f30913db0b51d3ecb0e93e97bb57e9bd5802d5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…eck during eval, a=testonly Automatic update from web-platform-tests [csp] test order of host callout & typecheck during eval (#16301) * [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands. -- wpt-commits: e3d0146264093a389148cc555ee9be69bd75719b wpt-pr: 16301 UltraBlame original commit: 88f30913db0b51d3ecb0e93e97bb57e9bd5802d5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…eck during eval, a=testonly Automatic update from web-platform-tests [csp] test order of host callout & typecheck during eval (#16301) * [js] test order of host callout & typecheck during eval This adds tests for tc39/ecma262#1504 which cannot be tested purely in JavaScript because it involves HostEnsureCanCompileStrings. As documented in a table on tc39/ecma262#1495 this passes on recent Chrome and Safari and fails on Firefox so this test probably shouldn't land right away. * Moved test to content-security-policy/generic I reformatted it to follow the guidance at https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L37-L60 and moved the `<meta http-equiv=Content-Security-Policy>` content into a separate file per https://github.com/web-platform-tests/wpt/blob/38f02ed8bb05f69ab4b061d17220f8f46709a0a3/content-security-policy/README.html#L22-L24 * move `<title>` into `<head>` * Mark new test tentative ... until tc39/ecma262#1495 lands. -- wpt-commits: e3d0146264093a389148cc555ee9be69bd75719b wpt-pr: 16301 UltraBlame original commit: 88f30913db0b51d3ecb0e93e97bb57e9bd5802d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1495
which identifies the ordering of host callouts and input
type checks as a spec bug.
This uses option 1 from
#1495 (comment)
to ensure that type checks happen before host callouts.
This can't be tested in test262 but if this lands, I will follow up
with tests via web-platform-tests/wpt.