Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updater file name with spaces and v2 sig files #845

Merged
merged 9 commits into from
Jul 2, 2024

Conversation

Legend-Master
Copy link
Contributor

Fixes #843

@Legend-Master
Copy link
Contributor Author

I don't know how I gonna test this to be honest 😖

@FabianLars
Copy link
Member

we can merge this (after ci is happy) and see how the ci run on the dev branch behaves. Or if you enable ci in your fork it should also upload everything to a draft release there.

@FabianLars
Copy link
Member

Or maybe not quite. Just noticed that it skips the upload on the dev branch...

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jul 2, 2024

I'll try to run it in my fork, at the mean time, do you know what is our updater public key? Seems like there's private key set in the actions, but no public key's found

@FabianLars
Copy link
Member

@Legend-Master
Copy link
Contributor Author

@FabianLars
Copy link
Member

Ah that looks like my mistake, try adding this: f8044a1#diff-eab77d5479dfaa2e1e42c5a470ba2543fd78189b8a71e9de66c2f0b1ba74cb2fR46

<space>( will get converted to . by github but our logic converts it to ..

@Legend-Master
Copy link
Contributor Author

Looking at https://github.com/Legend-Master/tauri-action-test/releases/tag/3 signature files seem missing, not sure if it's related to ./.. to be honest

@FabianLars
Copy link
Member

Yeah, the looking for artifcats log is also wrong, only checking for v1 sigs

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jul 2, 2024

Trying it on https://github.com/Legend-Master/tauri-action-test/actions/runs/9757784582, upload sig files seem to work now, but not getting the asset for updater json

@Legend-Master Legend-Master changed the title fix: updater file name with spaces in them fix: updater file name with spaces in them and v2 sig files Jul 2, 2024
@Legend-Master Legend-Master changed the title fix: updater file name with spaces in them and v2 sig files fix: updater file name with spaces and v2 sig files Jul 2, 2024
@FabianLars FabianLars merged commit 621de48 into tauri-apps:dev Jul 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest.json file is not generated if productName contains spaces
2 participants