-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updater file name with spaces and v2 sig files #845
fix: updater file name with spaces and v2 sig files #845
Conversation
I don't know how I gonna test this to be honest 😖 |
we can merge this (after ci is happy) and see how the ci run on the dev branch behaves. Or if you enable ci in your fork it should also upload everything to a draft release there. |
Or maybe not quite. Just noticed that it skips the upload on the dev branch... |
I'll try to run it in my fork, at the mean time, do you know what is our updater public key? Seems like there's private key set in the actions, but no public key's found |
Hmm, still doesn't work yet
|
Ah that looks like my mistake, try adding this: f8044a1#diff-eab77d5479dfaa2e1e42c5a470ba2543fd78189b8a71e9de66c2f0b1ba74cb2fR46
|
Looking at https://github.com/Legend-Master/tauri-action-test/releases/tag/3 signature files seem missing, not sure if it's related to |
Yeah, the looking for artifcats log is also wrong, only checking for v1 sigs |
Trying it on https://github.com/Legend-Master/tauri-action-test/actions/runs/9757784582, upload sig files seem to work now, but not getting the asset for updater json |
Fixes #843