fix: Detect v1 bundles with ()[]{} removed from productName. (#837)

* fix: Detect v1 bundles with `()[]{}` removed from productName.

* add parans to tests

* regex 101

* accomodate github's asset renaming

* log

* .. -> .

* rm log

.changes/fix-parans-in-prodname.md

@@ -0,0 +1,5 @@
+---
+action: patch
+---
+
+Fixed an issue that caused the action to be unable to pick up the app bundles if the `productName` contained any of these characters: `()[]{}`.

.github/fixtures/example-with-tauri-v1/src-tauri/tauri.conf.json

@@ -6,7 +6,7 @@
     "beforeBuildCommand": ""
   },
   "package": {
-    "productName": "TauriExample App",
+    "productName": "TauriExample App (v1)",
     "version": "0.1.1"
   },
   "tauri": {

.github/fixtures/example-with-tauri-v2/src-tauri/tauri.conf.json

@@ -1,5 +1,5 @@
 {
-  "productName": "TauriExample App",
+  "productName": "TauriExample App (v2)",
   "version": "0.1.2",
   "identifier": "com.tauri.actiontest",
   "build": {

src/build.ts

@@ -65,12 +65,13 @@ export async function buildProject(
 
   await runner.execTauriCommand(['build'], [...tauriArgs], root);
 
-  // on Linux, the app product name is converted to kebab-case
+  // on Linux, the app product name is converted to kebab-case and `()[]{}` will be removed
   // with tauri-cli 2.0.0-beta.19 deb and appimage will now use the product name as on the other platforms.
   const linuxFileAppName = app.name
     .replace(/([a-z0-9])([A-Z])/g, '$1-$2')
     .replace(/([A-Z])([A-Z])(?=[a-z])/g, '$1-$2')
     .replace(/[ _.]/g, '-')
+    .replace(/[()[\]{}]/g, '')
     .toLowerCase();
 
   const workspacePath = getWorkspaceDir(app.tauriPath) ?? app.tauriPath;

src/upload-release-assets.ts

@@ -38,7 +38,12 @@ export async function uploadAssets(
     const assetName = getAssetName(asset.path);
 
     const existingAsset = existingAssets.find(
-      (a) => a.name === assetName.trim().replace(/ /g, '.'),
+      (a) =>
+        a.name ===
+        assetName
+          .trim()
+          .replace(/[ ()[\]{}]/g, '.')
+          .replace(/\.\./g, '.'),
     );
     if (existingAsset) {
       console.log(`Deleting existing ${assetName}...`);

src/upload-version-json.ts

@@ -99,7 +99,11 @@ export async function uploadVersionJSON({
   }
 
   const assetNames = new Set(
-    artifacts.map((p) => getAssetName(p.path).trim().replace(/ /g, '.')), // GitHub replaces spaces in asset names with dots
+    artifacts.map((p) =>
+      getAssetName(p.path)
+        .trim()
+        .replace(/[ ()[\]{}]/g, '.'),
+    ), // GitHub replaces spaces and special chars in asset names with dots
   );
   let downloadUrl;
   {