fix(sandboxed): fix detecting special errors by sending default messages #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Dec 13, 2024
| @@ -13,7 +13,7 @@ module.exports = function (job) { | |||
| throw new Error('Not yet!'); | |||
| } | |||
| if (job.attemptsMade < 2) { | |||
| throw new UnrecoverableError('Unrecoverable'); | |||
| throw new UnrecoverableError(); | |||
There was a problem hiding this comment.
Will this still work if the user passes a different message?
roggervalf
force-pushed
the
fix-default-message-for-errors
branch
from
b55b28e to
2293b95
Compare
roggervalf
force-pushed
the
fix-default-message-for-errors
branch
from
2293b95 to
c0c6dae
Compare
manast
approved these changes
Dec 18, 2024
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Dec 22, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.32.0` -> `5.34.4`](https://renovatebot.com/diffs/npm/bullmq/5.32.0/5.34.4) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.34.4`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.4) [Compare Source](taskforcesh/bullmq@v5.34.3...v5.34.4) ##### Bug Fixes - **sandbox:** fix issue where job could stay in active forever ([#​2979](taskforcesh/bullmq#2979)) ([c0a6bcd](taskforcesh/bullmq@c0a6bcd)) ### [`v5.34.3`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.3) [Compare Source](taskforcesh/bullmq@v5.34.2...v5.34.3) ##### Bug Fixes - **sandboxed:** fix detecting special errors by sending default messages ([#​2967](taskforcesh/bullmq#2967)) fixes [#​2962](taskforcesh/bullmq#2962) ([52b0e34](taskforcesh/bullmq@52b0e34)) ### [`v5.34.2`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.2) [Compare Source](taskforcesh/bullmq@v5.34.1...v5.34.2) ##### Bug Fixes - **scripts:** make sure jobs fields are not empty before unpack ([4360572](taskforcesh/bullmq@4360572)) ### [`v5.34.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.1) [Compare Source](taskforcesh/bullmq@v5.34.0...v5.34.1) ##### Bug Fixes - guarantee every repeatable jobs are slotted ([9917df1](taskforcesh/bullmq@9917df1)) - **job-scheduler:** avoid duplicated delayed jobs when repeatable jobs are retried ([af75315](taskforcesh/bullmq@af75315)) ### [`v5.34.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.0) [Compare Source](taskforcesh/bullmq@v5.33.1...v5.34.0) ##### Features - **telemetry:** add option to omit context propagation on jobs ([#​2946](taskforcesh/bullmq#2946)) ([6514c33](taskforcesh/bullmq@6514c33)) ### [`v5.33.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.33.1) [Compare Source](taskforcesh/bullmq@v5.33.0...v5.33.1) ##### Bug Fixes - **job-scheduler:** omit deduplication and debounce options from template options ([#​2960](taskforcesh/bullmq#2960)) ([b5fa6a3](taskforcesh/bullmq@b5fa6a3)) ### [`v5.33.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.33.0) [Compare Source](taskforcesh/bullmq@v5.32.0...v5.33.0) ##### Features - replace multi by lua scripts in moveToFailed ([#​2958](taskforcesh/bullmq#2958)) ([c19c914](taskforcesh/bullmq@c19c914)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/403 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2962