-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: DelayError throwing in Child Processor breaks without Message #2962
Labels
bug
Something isn't working
Comments
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this issue
Dec 22, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.32.0` -> `5.34.4`](https://renovatebot.com/diffs/npm/bullmq/5.32.0/5.34.4) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.34.4`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.4) [Compare Source](taskforcesh/bullmq@v5.34.3...v5.34.4) ##### Bug Fixes - **sandbox:** fix issue where job could stay in active forever ([#​2979](taskforcesh/bullmq#2979)) ([c0a6bcd](taskforcesh/bullmq@c0a6bcd)) ### [`v5.34.3`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.3) [Compare Source](taskforcesh/bullmq@v5.34.2...v5.34.3) ##### Bug Fixes - **sandboxed:** fix detecting special errors by sending default messages ([#​2967](taskforcesh/bullmq#2967)) fixes [#​2962](taskforcesh/bullmq#2962) ([52b0e34](taskforcesh/bullmq@52b0e34)) ### [`v5.34.2`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.2) [Compare Source](taskforcesh/bullmq@v5.34.1...v5.34.2) ##### Bug Fixes - **scripts:** make sure jobs fields are not empty before unpack ([4360572](taskforcesh/bullmq@4360572)) ### [`v5.34.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.1) [Compare Source](taskforcesh/bullmq@v5.34.0...v5.34.1) ##### Bug Fixes - guarantee every repeatable jobs are slotted ([9917df1](taskforcesh/bullmq@9917df1)) - **job-scheduler:** avoid duplicated delayed jobs when repeatable jobs are retried ([af75315](taskforcesh/bullmq@af75315)) ### [`v5.34.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.34.0) [Compare Source](taskforcesh/bullmq@v5.33.1...v5.34.0) ##### Features - **telemetry:** add option to omit context propagation on jobs ([#​2946](taskforcesh/bullmq#2946)) ([6514c33](taskforcesh/bullmq@6514c33)) ### [`v5.33.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.33.1) [Compare Source](taskforcesh/bullmq@v5.33.0...v5.33.1) ##### Bug Fixes - **job-scheduler:** omit deduplication and debounce options from template options ([#​2960](taskforcesh/bullmq#2960)) ([b5fa6a3](taskforcesh/bullmq@b5fa6a3)) ### [`v5.33.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.33.0) [Compare Source](taskforcesh/bullmq@v5.32.0...v5.33.0) ##### Features - replace multi by lua scripts in moveToFailed ([#​2958](taskforcesh/bullmq#2958)) ([c19c914](taskforcesh/bullmq@c19c914)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/403 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v5.29.1
Platform
NodeJS
What happened?
Description
Throwing
DelayedError
doesn't work properly with child processor sandboxing, if you don't pass amessage
to the thrown error. This appears to be because when sending a message to the parent that a child failed, it checks if there's anerr.message
property, and if not, wraps the error withnew Error(err)
which causes thename
property to be overwritten asError
so that the checks forerr.name === 'DelayedError
in theWorker
class are incorrect.How to reproduce.
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: