-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre-mine introduce temp ban and add counters #6612
Merged
SWvheerden
merged 3 commits into
tari-project:development
from
hansieodendaal:ho_add_pre_mine_counters
Oct 8, 2024
Merged
feat: pre-mine introduce temp ban and add counters #6612
SWvheerden
merged 3 commits into
tari-project:development
from
hansieodendaal:ho_add_pre_mine_counters
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pre-mine counters so the progress could be displayed.
SWvheerden
changed the title
feat: pre-mine introduce temp ban and add counters
feat: pre-mine introduce temp ban and add counters
Oct 8, 2024
ghpbot-tari-project
added
P-acks_required
Process - Requires more ACKs or utACKs
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
labels
Oct 8, 2024
Test Results (CI) 3 files 129 suites 33m 43s ⏱️ Results for commit a16f96d. |
Test Results (Integration tests)36 tests 36 ✅ 14m 28s ⏱️ Results for commit a16f96d. |
SWvheerden
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a nit about the text
applications/minotari_console_wallet/src/automation/commands.rs
Outdated
Show resolved
Hide resolved
applications/minotari_console_wallet/src/automation/commands.rs
Outdated
Show resolved
Hide resolved
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 10, 2024
* development: chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617) feat: improve mempool error msg when mempool out of sync (tari-project#6618) feat: exit logic for pre-mine spend (tari-project#6615) chore: new release esme v1.6.0-pre.0 (tari-project#6614) feat: enable identity grpc method by default (tari-project#6613) feat: pre-mine introduce temp ban and add counters (tari-project#6612) chore: changes mainnet default network (tari-project#6610) chore(ci): add riscv64 builds and misc script fixes (tari-project#6611) feat!: esme test pre-mine with immediate spend (tari-project#6609) feat!: add context to ffi callbacks (tari-project#6608) feat: add default exclude dial (tari-project#6607) feat!: add input mr into genesis block (tari-project#6601) feat: update pre_mine specification (tari-project#6606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P-acks_required
Process - Requires more ACKs or utACKs
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pre-mine-spend-encumber-aggregate-utxo
andpre-mine-spend-aggregate-transaction
to prevent the wallet from broadcasting the incomplete transactions.Motivation and Context
Improved UX
How Has This Been Tested?
System-level testing
What process can a PR reviewer use to test or verify this change?
Code review
Breaking Changes