feat!: add context to ffi callbacks #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration test
Test Results (CI) 3 files 129 suites 37m 7s ⏱️ Results for commit ff494bd. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
brianp
previously approved these changes
Oct 8, 2024
ghpbot-tari-project
removed
the
P-reviews_required
|
yeah its any pointer, but I dont think you can choose the wallet pointer in the way its constructed. As you need to provide the pointer before you get the wallet? |
ghpbot-tari-project
added
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 10, 2024
* development: chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617) feat: improve mempool error msg when mempool out of sync (tari-project#6618) feat: exit logic for pre-mine spend (tari-project#6615) chore: new release esme v1.6.0-pre.0 (tari-project#6614) feat: enable identity grpc method by default (tari-project#6613) feat: pre-mine introduce temp ban and add counters (tari-project#6612) chore: changes mainnet default network (tari-project#6610) chore(ci): add riscv64 builds and misc script fixes (tari-project#6611) feat!: esme test pre-mine with immediate spend (tari-project#6609) feat!: add context to ffi callbacks (tari-project#6608) feat: add default exclude dial (tari-project#6607) feat!: add input mr into genesis block (tari-project#6601) feat: update pre_mine specification (tari-project#6606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds c_void context pointer to all FFI callbacks
Splits get address functions into interactive and one-sided
Motivation and Context
By adding a c_void pointer to the all callbacks, each callback can be identified by the context to know from what wallet the callback comes from.
Identifying the callback becomes important if you are running more than one wallet and thus need to identify the calling wallet.
Allows the FFI to get both the interactive and one-sided addresses from the wallet.
Breaking Changes
Adds c_void context to all callbacks.
Renames get_wallet_address to get_wallet_interactive_addess and adds get_wallet_one_sided_address