Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: covenants integration #3681

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 4, 2022

Description

  • add covenants to txos
  • validate covenants for transactions and blocks

Motivation and Context

Based on #3656

How Has This Been Tested?

New unit test
Manually on dibbler, mined a few blocks and a sent transaction (empty covenant)

@sdbondi sdbondi marked this pull request as draft January 4, 2022 06:26
@sdbondi sdbondi force-pushed the core-covenants-integration branch from f1af1b2 to 3209750 Compare January 4, 2022 11:32
@sdbondi sdbondi marked this pull request as ready for review January 4, 2022 11:34
@sdbondi sdbondi marked this pull request as draft January 4, 2022 11:35
@sdbondi
Copy link
Member Author

sdbondi commented Jan 4, 2022

Draft until #3656 is merged

* development: (28 commits)
  feat: covenants implementation (tari-project#3656)
  ci: add tor script to binaries bundle (tari-project#3689)
  chore: remove testnet reset todo in wallet (tari-project#3685)
  feat: dibbler new genesis block with faucet utxos (tari-project#3688)
  ci: fix clippy warning on generated proto module (tari-project#3690)
  test: fix metadata signature cucumber (tari-project#3687)
  refactor!: clean up #testnet reset TODOs (tari-project#3682)
  feat(comms)!: add signature to peer identity to allow third party identity updates (tari-project#3629)
  chore: remove moving lock.mdb (tari-project#3674)
  chore: merge weatherwax
  feat!: provide a compact form of TransactionInput (tari-project#3460)
  fix: allow 0-conf in blockchain db (tari-project#3680)
  v0.22.1.1
  v0.22.1
  ci: add build step (tari-project#3678)
  test: fix cucumber WalletQuery.feature (tari-project#3677)
  test: fix `wait for` step (tari-project#3673)
  fix: edge cases causing bans during header/block sync (tari-project#3661)
  perf(comms)!: optimise connection establishment (tari-project#3658)
  fix: end stale outbound queue immediately on disconnect, retry outbound messages (tari-project#3664)
  ...
@sdbondi sdbondi marked this pull request as ready for review January 11, 2022 16:34
@sdbondi sdbondi force-pushed the core-covenants-integration branch 2 times, most recently from 2695590 to 8d8153d Compare January 11, 2022 18:33
@sdbondi sdbondi force-pushed the core-covenants-integration branch from 8d8153d to ace1217 Compare January 11, 2022 18:33
@sdbondi sdbondi force-pushed the core-covenants-integration branch from 408622d to a368749 Compare January 12, 2022 06:44
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the implementation, but I would prefer the covenant field to be part of the OutputFeatures struct

stringhandler
stringhandler previously approved these changes Jan 12, 2022
* development:
  fix(comms): improve simultaneous connection handling (tari-project#3697)
  refactor(mempool)!: optimisations,excess sig index,fix weight calc (tari-project#3691)
@sdbondi sdbondi force-pushed the core-covenants-integration branch from 1c9984a to eb5c6cd Compare January 12, 2022 14:33
stringhandler
stringhandler previously approved these changes Jan 12, 2022
@aviator-app aviator-app bot added mq-failed and removed mq-failed labels Jan 12, 2022
@aviator-app aviator-app bot removed the mq-failed label Jan 13, 2022
@aviator-app aviator-app bot merged commit 2ff6fed into tari-project:development Jan 13, 2022
@sdbondi sdbondi deleted the core-covenants-integration branch January 13, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants