-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: covenants integration #3681
Merged
aviator-app
merged 18 commits into
tari-project:development
from
sdbondi:core-covenants-integration
Jan 13, 2022
Merged
feat!: covenants integration #3681
aviator-app
merged 18 commits into
tari-project:development
from
sdbondi:core-covenants-integration
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-covenants-integration
branch
from
January 4, 2022 11:32
f1af1b2
to
3209750
Compare
Draft until #3656 is merged |
* development: (28 commits) feat: covenants implementation (tari-project#3656) ci: add tor script to binaries bundle (tari-project#3689) chore: remove testnet reset todo in wallet (tari-project#3685) feat: dibbler new genesis block with faucet utxos (tari-project#3688) ci: fix clippy warning on generated proto module (tari-project#3690) test: fix metadata signature cucumber (tari-project#3687) refactor!: clean up #testnet reset TODOs (tari-project#3682) feat(comms)!: add signature to peer identity to allow third party identity updates (tari-project#3629) chore: remove moving lock.mdb (tari-project#3674) chore: merge weatherwax feat!: provide a compact form of TransactionInput (tari-project#3460) fix: allow 0-conf in blockchain db (tari-project#3680) v0.22.1.1 v0.22.1 ci: add build step (tari-project#3678) test: fix cucumber WalletQuery.feature (tari-project#3677) test: fix `wait for` step (tari-project#3673) fix: edge cases causing bans during header/block sync (tari-project#3661) perf(comms)!: optimise connection establishment (tari-project#3658) fix: end stale outbound queue immediately on disconnect, retry outbound messages (tari-project#3664) ...
sdbondi
force-pushed
the
core-covenants-integration
branch
2 times, most recently
from
January 11, 2022 18:33
2695590
to
8d8153d
Compare
sdbondi
force-pushed
the
core-covenants-integration
branch
from
January 11, 2022 18:33
8d8153d
to
ace1217
Compare
sdbondi
force-pushed
the
core-covenants-integration
branch
from
January 12, 2022 06:44
408622d
to
a368749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the implementation, but I would prefer the covenant field to be part of the OutputFeatures struct
stringhandler
previously approved these changes
Jan 12, 2022
* development: fix(comms): improve simultaneous connection handling (tari-project#3697) refactor(mempool)!: optimisations,excess sig index,fix weight calc (tari-project#3691)
sdbondi
force-pushed
the
core-covenants-integration
branch
from
January 12, 2022 14:33
1c9984a
to
eb5c6cd
Compare
stringhandler
previously approved these changes
Jan 12, 2022
sdbondi
force-pushed
the
core-covenants-integration
branch
from
January 12, 2022 18:08
079872e
to
5d3d70f
Compare
stringhandler
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Based on #3656
How Has This Been Tested?
New unit test
Manually on dibbler, mined a few blocks and a sent transaction (empty covenant)