refactor(mempool)!: optimisations,excess sig index,fix weight calc #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-mempool-optimisations
branch
from
8cbfec3 to
6aa7cf4
Compare
sdbondi
changed the title
delta1
reviewed
Jan 10, 2022
base_layer/core/src/mempool/priority/prioritized_transaction.rs
Outdated
Show resolved
Hide resolved
sdbondi
force-pushed
the
core-mempool-optimisations
branch
from
6aa7cf4 to
62c9dd7
Compare
sdbondi
force-pushed
the
core-mempool-optimisations
branch
from
62c9dd7 to
6710053
Compare
sdbondi
force-pushed
the
core-mempool-optimisations
branch
from
6710053 to
babf00b
Compare
SWvheerden
reviewed
Jan 11, 2022
* development: feat: covenants implementation (tari-project#3656) ci: add tor script to binaries bundle (tari-project#3689)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 12, 2022
* development: fix(comms): improve simultaneous connection handling (tari-project#3697) refactor(mempool)!: optimisations,excess sig index,fix weight calc (tari-project#3691)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 12, 2022
* development: fix(comms): improve simultaneous connection handling (tari-project#3697) refactor(mempool)!: optimisations,excess sig index,fix weight calc (tari-project#3691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(∑v_i) / d != v_1 / d + v_2/d +.... v_n/dunless allvs are multiples ofddue to integer rounding)Because the block weight calculation changed, this is a breaking change only affecting full/near full blocks
Motivation and Context
A bug in the way metadata weights are calculated meant that a set of transactions can have a different total weight from a block containing those same transactions. After a correctly weighted full block is returned from get block template, the block validator could incorrectly reject a block once mined as exceeding maximum weight.
Create a many to many index between transactions and kernels in the mempool.
How Has This Been Tested?
Unit: Existing tests updated
Manual: Producing 3 blocks worth of transactions, mining and checking the block is accepted and the transactions removed from the mempool