Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console wallet] show base node chain tip and sync status #2420

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Nov 4, 2020

Description

Replaces the placeholder data with live data from the base node service. Adds a configuration option to specify which base node the wallet should connect to, and then displays the chain tip and sync status.

Motivation and Context

The console wallet is still using some placeholder information

How Has This Been Tested?

Manually - you can use the following setting to point the wallet to tbn-oregon base node in config.toml

[wallet]
base_node_service_peer = "e856839057aac496b9e25f10821116d02b58f20129e9b9ba681b830568e47c4d::/onion3/exe2zgehnw3tvrbef3ep6taiacr6sdyeb54be2s25fpru357r4skhtad:18141"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@delta1 delta1 requested a review from philipr-za November 4, 2020 14:19
@delta1 delta1 marked this pull request as draft November 5, 2020 07:45
@delta1 delta1 force-pushed the wallet-show-bn branch 5 times, most recently from 63f21ee to d895b76 Compare November 6, 2020 15:12
@delta1 delta1 marked this pull request as ready for review November 6, 2020 16:27
@delta1 delta1 requested a review from philipr-za November 6, 2020 18:24
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, couple small comments.

applications/tari_console_wallet/src/main.rs Outdated Show resolved Hide resolved
applications/tari_console_wallet/src/main.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/wallet.rs Outdated Show resolved Hide resolved
Replaces the placeholder data with live data from the base node service.
Adds a configuration option to specify which base node the wallet should
connect to, and then displays the chain tip and sync status.
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stringhandler stringhandler merged commit b349d2e into tari-project:development Nov 11, 2020
stringhandler added a commit that referenced this pull request Nov 24, 2020
Major changes since v0.6.0
---
- [#2431](#2431) Database refactor to remove checkpoints and more efficient calculation of MMR roots
- [#2352](#2352) Add DNS seed support in base node

Minor changes since v0.6.0
---
- [#2448](#2448) Add OpenSSL to Windows install, runtime
- [#2434](#2434) Add supervisord setup notes
- [#2439](#2439) Provide initial sync status to merge mining proxy
- [#2377](#2377) Message malleability detect and ban
- [#2447](#2447) Fix for xmrig powershell script
- [#2440](#2440) Stagenet Setup Guide Corrections
- [#2444](#2444) DHT connectivity waits for comms connectivity before starting
- [#2427](#2427) Update merge mining runtime, README, Win install
- [#2420](#2420) Show base node chain tip and sync status in the console wallet
- [#2419](#2419) Add optional fee_per_gram field to console wallet Send Tx form
- [#2421](#2421) Fix QR code rendering in the console wallet
- [#2423](#2423) Plumb in the balance in the console wallet
- [#2415](#2415) Prevent loop in peer sync by storing all peers attempted
- [#2383](#2383) Implement daemon-mode in tari_base_node
- [#2407](#2407) Simplify automated stress test
- [#2397](#2397) Fix preset config files
- [#2400](#2400) Implement wallet base node service
- [#2403](#2403) Add exclusive file locks to Wallet, Chain and Peer db’s
- [#2408](#2408) Fix wallet conversion error for a valid tx status
- [#2356](#2356) Combine validation code to use same function in pruned and archive mode.
- [#2371](#2371) Add configurable BN service request timeouts
- [#2430](#2430) Implement entry and persistence of custom base node in console wallet
@delta1 delta1 deleted the wallet-show-bn branch December 3, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants