Protect against possible panics in header/horizon sync #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two missing checks in the header sync and horizon sync. These checks exit early if the headers/utxo set is aready synchonized or is ahead of the peer. Previously if this case occurred, the counter iterator would panic (start > end is invalid).
sdbondi
force-pushed
the
sb-core-fix-horizon-sync-panic
branch
from
ec3360a to
844c1fd
Compare
stringhandler
added a commit
that referenced
this pull request
Sep 18, 2020
Major Fixes since v0.5.4 * Many fixes and updates to tari_merge_mining_proxy * Implement transaction negotiation message resending in the wallet (#2161) Minor Fixes * Added basic RPC interface for DHT (#2188) * Refactor Tokio runtime out of wallet container (#2213) * Add period stats UI call (#2189) * Protect against possible panics in header/horizon sync (#2219) * Fix coinbase vulnerability (#2143) * Added a user configurable chain monitoring timeout (#2202) * Implement LMDB automatic resizing * Add `is_synced` flag to BaseNodeServiceResponse & update UTXO validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two missing checks in the header sync and horizon sync.
These checks exit early if the headers/utxo set is aready synchonized or
is ahead of the peer. Previously if this case occurred, the counter iterator
would panic (start > end is invalid).
Motivation and Context
Remove the possibility of a failed assertion (panic) in the base node.
How Has This Been Tested?
Header sync tested with base node.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.