Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add period stats UI call #2189

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

SWvheerden
Copy link
Collaborator

Description

This adds a UI call to get stats out of the block chain for a certain period, by interval count.
It is called by period-stats [start time] [end time] [counting interval]

Motivation and Context

We require stats for insight into the chain. This call is here to provide the stats we want in easy to copy csv format so it can easily be ported to sheets, or excel etc.
Currently it only has:
tx count, hash estimation, target difficulty, solve time

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

philipr-za
philipr-za previously approved these changes Sep 14, 2020
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 1517 to 1519
// let period_end = 1590969600;
// let mut period_ticker_end = 1593561600;
// let period = 86400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// let period_end = 1590969600;
// let mut period_ticker_end = 1593561600;
// let period = 86400;

@stringhandler stringhandler merged commit 59b9a92 into tari-project:development Sep 15, 2020
stringhandler added a commit that referenced this pull request Sep 18, 2020
Major Fixes since v0.5.4
* Many fixes and updates to tari_merge_mining_proxy
* Implement transaction negotiation message resending in the wallet (#2161)

Minor Fixes
* Added basic RPC interface for DHT (#2188)
* Refactor Tokio runtime out of wallet container (#2213)
* Add period stats UI call (#2189)
* Protect against possible panics in header/horizon sync (#2219)
* Fix coinbase vulnerability (#2143)
* Added a user configurable chain monitoring timeout (#2202)
* Implement LMDB automatic resizing
* Add `is_synced` flag to BaseNodeServiceResponse & update UTXO validator
@SWvheerden SWvheerden deleted the sw_month_stats branch October 7, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants