Windows block validation tests fix #2023
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rolled back the
rust-toolchain
,clear_on_drop
andtari_crypto
due to certain block validation tests failing in Windows.These validation tests now pass:
test test_block_33923 ... ok
test test_block_34947 ... ok
test test_block_30335 ... ok
test test_block_9182 ... ok
TODO: Further investigation is needed to fix the cause of the problem, see registered issue #2022.
Motivation and Context
Commit df95cee introduced a bug in Windows builds that resulted in blocks 9182, 30335, 33923 and 34947 failing validation tests. e,g,:
This originates from
fn validate_kernel_sum(...)
inaggregated_body.rs
, asfn sum_kernels(...)
returns the wrong result.The problem is caused by updating Rust toolchain to
nightly-2020-06-10
fromnightly-2020-01-08
andclear_on_drop
to0.2.4
from0.2.3
.How Has This Been Tested?
tari_base_node.exe
in Windows, starting the blockchain from the last known good state at heights 9181, 30334, 33922 and 34946.base_layer\core\tests\regression_tests.rs
also passed.Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.