Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust toolchain nightly-2020-06-10 causing block validation in Windows to fail. #2022

Closed
hansieodendaal opened this issue Jun 24, 2020 · 2 comments · Fixed by #2035
Closed
Assignees
Labels
C-bug Category - fixes a bug, typically associated with an issue. X-windows Platform - Windows

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented Jun 24, 2020

Describe the bug
Commit df95cee introduced a bug in Windows builds that resulted in blocks 9182, 30335, 33923 and 34947 failing validation tests. e,g,:

2020-06-18 11:39:51.632946300 [c::bn::comms_interface::inbound_handler] WARN  Block #33923 
   (3a541cf21e19650697d8d785ba9b5f38e86868af94a7fca4adec3c3bcf93aef1) validation failed: ValidationError { source: 
   TransactionError(ValidationError("Sum of inputs and outputs did not equal sum of kernels with fees")) }

This originates from fn validate_kernel_sum(...) in aggregated_body.rs, as fn sum_kernels(...) returns the wrong result.
The problem is caused by updating Rust toolchain to nightly-2020-06-10 from nightly-2020-01-08.

To Reproduce
Steps to reproduce the behaviour:

  1. Ceck out commit hash ab70a86 from development branch dated 2020/06/24 12:22:24
  2. Run cargo test -p tari_core --test regression_tests

Expected behaviour
When using Rust toolchain nightly-2020-06-10 all tests should pass:

running 4 tests
test test_block_33923 ... ok
test test_block_34947 ... ok
test test_block_30335 ... ok
test test_block_9182 ... ok

Screenshots
n/a

Desktop (please complete the following information):

  • Windows 10

Smartphone (please complete the following information):

  • n/a

Additional context
n/a

@hansieodendaal hansieodendaal changed the title Rust toolchain nightly-2020-06-10 and clear_on_drop 0.2.4 causing block validation in Windows to fail. Rust toolchain nightly-2020-06-10 causing block validation in Windows to fail. Jun 29, 2020
@Tas4tari Tas4tari added the C-bug Category - fixes a bug, typically associated with an issue. label Jun 29, 2020
@stringhandler
Copy link
Collaborator

@hansieodendaal is this still occuring?

@hansieodendaal
Copy link
Contributor Author

Hi @mikethetike, fixed by #2035. It can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - fixes a bug, typically associated with an issue. X-windows Platform - Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants