Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forward sync explicit index ref #1956

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix forward sync explicit index ref #1956

merged 1 commit into from
Jun 5, 2020

Conversation

SWvheerden
Copy link
Collaborator

Description

Fix forward sync explicit index ref

Motivation and Context

There was no check if length of blocks received was 0 in one use of the blocks vec, this PR fixes that.

How Has This Been Tested?

Types of changes

  • [x Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

sdbondi
sdbondi reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

base_layer/core/src/base_node/states/forward_block_sync.rs Show resolved Hide resolved
@SWvheerden SWvheerden force-pushed the sw_fix_forward_sync branch from 5113b85 to 778d404 Compare June 5, 2020 09:06
sdbondi
sdbondi approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdbondi sdbondi merged commit f2a7bda into development Jun 5, 2020
@sdbondi sdbondi deleted the sw_fix_forward_sync branch June 5, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjS77 CjS77 CjS77 left review comments

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @sdbondi @CjS77