Skip to content

Commit

Permalink
Fix forward sync index out of bounds (#1956)
Browse files Browse the repository at this point in the history
Merge pull request #1956

Fix forward sync index out of bounds error when no blocks are returned
from fetch blocks

* pull/1956/head:
  fix forward sync explicit index ref
  • Loading branch information
sdbondi committed Jun 5, 2020
2 parents 7959736 + 778d404 commit f2a7bda
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions base_layer/core/src/base_node/states/forward_block_sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,12 +237,13 @@ async fn download_blocks<B: BlockchainBackend + 'static>(
match shared.comms.fetch_blocks_with_hashes(curr_headers.clone()).await {
Ok(blocks) => {
info!(target: LOG_TARGET, "Received {} blocks from peer", blocks.len());

if let StatusInfo::BlockSync(ref mut info) = shared.info {
info.tip_height = Some(blocks[blocks.len() - 1].block().header.height);
info.local_height = Some(blocks[0].block().header.height);
if !blocks.is_empty() {
if let StatusInfo::BlockSync(ref mut info) = shared.info {
info.tip_height = Some(blocks[blocks.len() - 1].block().header.height);
info.local_height = Some(blocks[0].block().header.height);
}
shared.publish_event_info().await;
}
shared.publish_event_info().await;
for i in 0..blocks.len() {
let hist_block = &blocks[i];
let header = &curr_headers[i];
Expand Down

0 comments on commit f2a7bda

Please sign in to comment.