Don't mark peers as offline if there are no existing connections #1763
+36
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
offline while there are no active connections, in which case, the node
itself may have lost connection.
propagation of messages. Attempting to send a message directly will still
be attempted. There is existing protection for marking more than 70%
of neighbouring peers as offline, so this change is an additional
protection from both sides considering each other offline.
list-peers
command, even though logically they are not considered offline.
Motivation and Context
Nodes could mistakenly be marked as offline by a node experiencing loss of connection. This remedies that by requiring at least one active peer connection before marking any peer as offline. Unfortunately, tor takes a while to drop socks connections once the internet is cut off, TODO: look for settings in tor to fine tune this.
How Has This Been Tested?
No unit/integration tests (TODO). Tested locally by starting a base node, switching off wifi and checking that no peers are marked as offline.
Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.