-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty Emoji String Bug Fix #1736
Conversation
081a08c
to
22c542c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - nice catch. Style nits though :)
22c542c
to
8dfead5
Compare
Had a closer look; I think the bug is actually in
in case it's not clear, the current PR will still expose the same bug in |
8dfead5
to
24925e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
** Major Changes from 0.0.9 **** Store and forward Peers will hold onto message for recipients that are not online and deliver the messages to them when they appear again. **** OsX package installer **** Many documentation improvements **** Ephemeral keys for private messages This is a big change that preserves privacy on the network but dramatically reduces the amount of traffic peers have to deal with. **** Emoji Ids *** Other changes - The target difficulty for a specified PoW algorithm is included in the block header. This allows the target difficulty of any block height to be calculated by only processing the last set of target difficulty samples up to that height. - Don't mark peers as offline if there are no existing connections (#1763) - Add UTXO selection strategy for large txs - Base node: Dynamically determine build version (#1760) - Include random peers for liveness ping (#1753) - RandomX - Version Update (#1754) - Add generic debug log function to FFI (#1752) - Lots of logging improvements - Added list-transactions and cancel-transaction commands (#1746) - ASCII table output for list-peers and list-connections (#1709) - Improve Difficulty adjustment manager - Modular configuration via ConfigLoader and ConfigPath traits - Fix chain monitoring bug in Transaction Service (#1739) - Empty Emoji String Bug Fix (#1736) - Coin-split base node cli command - Complete the basic OSX pkg build - Perform reorgs only on stronger tip accumulated difficulties - Use filesystem storage for dht.db on libwallet (#1735) - Fix duplicate message propagation (#1730) - Introduced accumulated difficulty validators to allow different rules for testing and running running a base node. - - Changes to peer offline handling (#1716) - Update Transaction cancellation to work for Inbound and Outbound Txs - Added oneshot reply to outbound messaging (#1703) - Add transaction stress test command to CLI - Implemented basic `make-it-rain` command - Fix MmrCache rewind issue - Use ephemeral key for private messages (e.g Discovery) (#1686) - Limit orphan pool size - Added a function to list UTXOs in the console (#1678) - Prevent adding yourself as a peer (#1665) - Update transaction weights (#1661) - Fix block period calculation - Validators will now check the weight of a block when doing validation (#1648) - Cleaned up duplicate code from the Blockchain db - The ban peer log will now supply n reason why the peer was banned (#1638)
Description
Check if Emoji string is empty before trying to validate it.
Motivation and Context
Bug fix
How Has This Been Tested?
cargo test --all --all-features
Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.