Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OneNote File Extraction and Fix IOC Storage #389

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Aug 3, 2023

Summary of Change
This PR introduces some improvements to the ScanOnenote class in the strelka module and fixes the IOC feature to properly capture and store Indicators of Compromise (IOCs) in file events.

Changes Made

  1. Added a new constant ONE_NOTE_MAGIC for the binary string to search for in the data.
  2. In the ScanOnenote class, modified the scan method to capture statistics on the number of files processed and extracted.
  3. Fixed the collection of IOCs during the scanning process.

Describe testing procedures
Tested ScanOnenote and AddIOC functionality with relevant scanners and files.

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer changed the title Ioc fix Improve OneNote File Extraction and Fix IOC Storage Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant