Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cmake to dockerfile for Lief #266

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

aaronherman
Copy link
Contributor

Describe the change
Adding Cmake to Dockerfile for Python build to fix an issue with lief install.

Closes #265

Describe testing procedures
Running docker-compose -f build/docker-compose.yaml build outputs

Building 1563.3s (46/46) FINISHED

Sample output
n/a

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer
Copy link
Contributor

This was on my own personal list to do, thanks for doing this, @aaronherman.

Tested and working on M1 + Intel based architecture.
Takes forever to build from scratch (On my M1, well over 20 minutes - mostly lief wheel build?). May be worth exploring registries to store prebuilt images.
For now, though, it works. 👍

@phutelmyer phutelmyer merged commit 8e090c5 into target:master Dec 27, 2022
@aaronherman aaronherman deleted the patch-1 branch December 28, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lief install on Mac M1
2 participants