Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a specific version of JTR (#13) #194

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Use a specific version of JTR (#13) #194

merged 1 commit into from
Jan 12, 2022

Conversation

cameron-dunn-sublime
Copy link
Contributor

@cameron-dunn-sublime cameron-dunn-sublime commented Jan 7, 2022 •
edited
Loading

Describe the change

  • Twice we've seen a build w/ JTR apparently unstable.
    • It's unclear if this is a build issue, or a result of grabbing
      a bad version (as we were just grabbing the repo head).
    • This ensures we grab the same commit, so if we continue to see
      issues we can go from there.
    • There are no even halfway recent tags so the commit is arbitrary.
  • Also changes the repo from magnumripper/JohnTheRipper to openwall/john
    as that's where the old repo forwards to.
  • And grab a single commit to speed things up (239 MB -> 140 ish MB).

Describe testing procedures
I've been running & rebuilding Strelka w/ these changes. This doesn't seem to have resolved JTR build issues but it may remove some possible causes.

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cameron-dunn-sublime
Use a specific version of JTR (#13)
4f0d966 
* Twice we've seen a build w/ JTR apparently unstable.
  * It's unclear if this is a build issue, or a result of grabbing
a bad version (as we were just grabbing the repo head).
  * This ensures we grab the same commit, so if we continue to see
issues we can go from there.
  * There are no even halfway recent tags so the commit is arbitrary.
* Also changes the repo from magnumripper/JohnTheRipper to openwall/john
as that's where the old repo forwards to.
* And grab a single commit to speed things up (239 MB -> 140 ish MB).
phutelmyer
phutelmyer approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@phutelmyer phutelmyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.
Looks good to me. Thank you!

@phutelmyer phutelmyer merged commit 7b6f038 into target:master Jan 12, 2022
@phutelmyer phutelmyer linked an issue Jan 12, 2022 that may be closed by this pull request
John The Ripper Inconsistency #193
Closed
@phutelmyer phutelmyer mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phutelmyer phutelmyer phutelmyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

John The Ripper Inconsistency
2 participants
@cameron-dunn-sublime @phutelmyer