Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a specific version of JTR #13

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Use a specific version of JTR #13

merged 1 commit into from
Dec 23, 2021

Conversation

cameron-dunn-sublime
Copy link
Member

@cameron-dunn-sublime cameron-dunn-sublime commented Dec 23, 2021

  • Twice we've seen a build w/ JTR apparently unstable.
    • It's unclear if this is a build issue, or a result of grabbing
      a bad version (as we were just grabbing the repo head).
    • This ensures we grab the same commit, so if we continue to see
      issues we can go from there.
    • There are no even halfway recent tags so the commit is arbitrary.
  • Also changes the repo from magnumripper/JohnTheRipper to openwall/john
    as that's where the old repo forwards to.
  • And grab a single commit to speed things up (239 MB -> 140 ish MB).

Describe testing procedures
Validated that intermittently failing test is passing (w/ cleared caches). This doesn't guarantee the issue is fixed, but at the very least nothing is worse.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

* Twice we've seen a build w/ JTR apparently unstable.
  * It's unclear if this is a build issue, or a result of grabbing
a bad version (as we were just grabbing the repo head).
  * This ensures we grab the same commit, so if we continue to see
issues we can go from there.
  * There are no even halfway recent tags so the commit is arbitrary.
* Also changes the repo from magnumripper/JohnTheRipper to openwall/john
as that's where the old repo forwards to.
* And grab a single commit to speed things up (239 MB -> 140 ish MB).
@cameron-dunn-sublime cameron-dunn-sublime requested a review from a team December 23, 2021 19:20
@itsojon itsojon self-assigned this Dec 23, 2021
@cameron-dunn-sublime cameron-dunn-sublime merged commit 28161d6 into main Dec 23, 2021
@cameron-dunn-sublime cameron-dunn-sublime deleted the cd.jtr-freeze branch December 23, 2021 21:31
cameron-dunn-sublime added a commit that referenced this pull request Jan 7, 2022
* Twice we've seen a build w/ JTR apparently unstable.
  * It's unclear if this is a build issue, or a result of grabbing
a bad version (as we were just grabbing the repo head).
  * This ensures we grab the same commit, so if we continue to see
issues we can go from there.
  * There are no even halfway recent tags so the commit is arbitrary.
* Also changes the repo from magnumripper/JohnTheRipper to openwall/john
as that's where the old repo forwards to.
* And grab a single commit to speed things up (239 MB -> 140 ish MB).
cameron-dunn-sublime pushed a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants